From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Skip request serialisation if the timeline is already complete Date: Wed, 7 Feb 2018 10:45:58 +0000 Message-ID: References: <20180207084350.3929-1-chris@chris-wilson.co.uk> <20180207084350.3929-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62D716E541 for ; Wed, 7 Feb 2018 10:46:01 +0000 (UTC) In-Reply-To: <20180207084350.3929-2-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzAyLzIwMTggMDg6NDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB0aGUgbGFzdCBy ZXF1ZXN0IG9uIHRoZSB0aW1lbGluZSBpcyBhbHJlYWR5IGNvbXBsZXRlLCB3ZSBkbyBub3QgbmVl ZAo+IHRvIGVtaXQgdGhlIHNlcmlhbGlzYXRpb24gYmFycmllcnMuCj4gCj4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyB8IDE0ICsrKysrKysrKy0tLS0tCj4gICAxIGZpbGUg Y2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBpbmRleCAzODRjYjQ5YWU0Y2MuLjhhMzViNTU5 MWUwZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBAQCAt OTk1LDcgKzk5NSw4IEBAIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqcmVxdWVzdCwgYm9vbCBmbHVzaF9jYWNoZXMpCj4gICAJbG9ja2RlcF9hc3Nl cnRfaGVsZCgmcmVxdWVzdC0+aTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gICAJdHJhY2VfaTkx NV9nZW1fcmVxdWVzdF9hZGQocmVxdWVzdCk7Cj4gICAKPiAtCS8qIE1ha2Ugc3VyZSB0aGF0IG5v IHJlcXVlc3QgZ2F6dW1wZWQgdXMgLSBpZiBpdCB3YXMgYWxsb2NhdGVkIGFmdGVyCj4gKwkvKgo+ ICsJICogTWFrZSBzdXJlIHRoYXQgbm8gcmVxdWVzdCBnYXp1bXBlZCB1cyAtIGlmIGl0IHdhcyBh bGxvY2F0ZWQgYWZ0ZXIKPiAgIAkgKiBvdXIgaTkxNV9nZW1fcmVxdWVzdF9hbGxvYygpIGFuZCBj YWxsZWQgX19pOTE1X2FkZF9yZXF1ZXN0KCkgYmVmb3JlCj4gICAJICogdXMsIHRoZSB0aW1lbGlu ZSB3aWxsIGhvbGQgaXRzIHNlcW5vIHdoaWNoIGlzIGxhdGVyIHRoYW4gb3Vycy4KPiAgIAkgKi8K PiBAQCAtMTAyMiw3ICsxMDIzLDggQEAgdm9pZCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRy bV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LCBib29sIGZsdXNoX2NhY2hlcykKPiAgIAkJV0FS TihlcnIsICJlbmdpbmUtPmVtaXRfZmx1c2goKSBmYWlsZWQ6ICVkIVxuIiwgZXJyKTsKPiAgIAl9 Cj4gICAKPiAtCS8qIFJlY29yZCB0aGUgcG9zaXRpb24gb2YgdGhlIHN0YXJ0IG9mIHRoZSBicmVh ZGNydW1iIHNvIHRoYXQKPiArCS8qCj4gKwkgKiBSZWNvcmQgdGhlIHBvc2l0aW9uIG9mIHRoZSBz dGFydCBvZiB0aGUgYnJlYWRjcnVtYiBzbyB0aGF0Cj4gICAJICogc2hvdWxkIHdlIGRldGVjdCB0 aGUgdXBkYXRlZCBzZXFubyBwYXJ0LXdheSB0aHJvdWdoIHRoZQo+ICAgCSAqIEdQVSBwcm9jZXNz aW5nIHRoZSByZXF1ZXN0LCB3ZSBuZXZlciBvdmVyLWVzdGltYXRlIHRoZQo+ICAgCSAqIHBvc2l0 aW9uIG9mIHRoZSByaW5nJ3MgSEVBRC4KPiBAQCAtMTAzMSw3ICsxMDMzLDggQEAgdm9pZCBfX2k5 MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LCBib29s IGZsdXNoX2NhY2hlcykKPiAgIAlHRU1fQlVHX09OKElTX0VSUihjcykpOwo+ICAgCXJlcXVlc3Qt PnBvc3RmaXggPSBpbnRlbF9yaW5nX29mZnNldChyZXF1ZXN0LCBjcyk7Cj4gICAKPiAtCS8qIFNl YWwgdGhlIHJlcXVlc3QgYW5kIG1hcmsgaXQgYXMgcGVuZGluZyBleGVjdXRpb24uIE5vdGUgdGhh dAo+ICsJLyoKPiArCSAqIFNlYWwgdGhlIHJlcXVlc3QgYW5kIG1hcmsgaXQgYXMgcGVuZGluZyBl eGVjdXRpb24uIE5vdGUgdGhhdAo+ICAgCSAqIHdlIG1heSBpbnNwZWN0IHRoaXMgc3RhdGUsIHdp dGhvdXQgaG9sZGluZyBhbnkgbG9ja3MsIGR1cmluZwo+ICAgCSAqIGhhbmdjaGVjay4gSGVuY2Ug d2UgYXBwbHkgdGhlIGJhcnJpZXIgdG8gZW5zdXJlIHRoYXQgd2UgZG8gbm90Cj4gICAJICogc2Vl IGEgbW9yZSByZWNlbnQgdmFsdWUgaW4gdGhlIGh3cyB0aGFuIHdlIGFyZSB0cmFja2luZy4KPiBA QCAtMTAzOSw3ICsxMDQyLDcgQEAgdm9pZCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LCBib29sIGZsdXNoX2NhY2hlcykKPiAgIAo+ICAgCXBy ZXYgPSBpOTE1X2dlbV9hY3RpdmVfcmF3KCZ0aW1lbGluZS0+bGFzdF9yZXF1ZXN0LAo+ICAgCQkJ CSAgICZyZXF1ZXN0LT5pOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCWlmIChwcmV2KSB7Cj4g KwlpZiAocHJldiAmJiAhaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocHJldikpIHsKPiAgIAkJ aTkxNV9zd19mZW5jZV9hd2FpdF9zd19mZW5jZSgmcmVxdWVzdC0+c3VibWl0LCAmcHJldi0+c3Vi bWl0LAo+ICAgCQkJCQkgICAgICZyZXF1ZXN0LT5zdWJtaXRxKTsKPiAgIAkJaWYgKGVuZ2luZS0+ c2NoZWR1bGUpCj4gQEAgLTEwNTksNyArMTA2Miw4IEBAIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0 KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwgYm9vbCBmbHVzaF9jYWNoZXMp Cj4gICAJbGlzdF9hZGRfdGFpbCgmcmVxdWVzdC0+cmluZ19saW5rLCAmcmluZy0+cmVxdWVzdF9s aXN0KTsKPiAgIAlyZXF1ZXN0LT5lbWl0dGVkX2ppZmZpZXMgPSBqaWZmaWVzOwo+ICAgCj4gLQkv KiBMZXQgdGhlIGJhY2tlbmQga25vdyBhIG5ldyByZXF1ZXN0IGhhcyBhcnJpdmVkIHRoYXQgbWF5 IG5lZWQKPiArCS8qCj4gKwkgKiBMZXQgdGhlIGJhY2tlbmQga25vdyBhIG5ldyByZXF1ZXN0IGhh cyBhcnJpdmVkIHRoYXQgbWF5IG5lZWQKPiAgIAkgKiB0byBhZGp1c3QgdGhlIGV4aXN0aW5nIGV4 ZWN1dGlvbiBzY2hlZHVsZSBkdWUgdG8gYSBoaWdoIHByaW9yaXR5Cj4gICAJICogcmVxdWVzdCAt IGkuZS4gd2UgbWF5IHdhbnQgdG8gcHJlZW1wdCB0aGUgY3VycmVudCByZXF1ZXN0IGluIG9yZGVy Cj4gICAJICogdG8gcnVuIGEgaGlnaCBwcmlvcml0eSBkZXBlbmRlbmN5IGNoYWluICpiZWZvcmUq IHdlIGNhbiBleGVjdXRlIHRoaXMKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK