Re: [PATCH 5/5] lib: Add copyright statements to files without one

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2022-08-11 at 09:19 +0100, Paul Barker wrote:
> On 11/08/2022 08:59, Richard Purdie wrote:
> > On Thu, 2022-08-11 at 08:57 +0100, Paul Barker wrote:
> > > On 10/08/2022 20:45, Richard Purdie wrote:
> > > > diff --git a/meta/lib/oeqa/runtime/cases/rtc.py b/meta/lib/oeqa/runtime/cases/rtc.py
> > > > index c4e66813249..223cf7b95d9 100644
> > > > --- a/meta/lib/oeqa/runtime/cases/rtc.py
> > > > +++ b/meta/lib/oeqa/runtime/cases/rtc.py
> > > > @@ -1,3 +1,8 @@
> > > > +\#
> > > 
> > > Looks like an extra '\' has slipped in here.
> > 
> > Thanks, well spotted! I've fixed in the branch.
> 
> I've also checked master-next with `reuse lint`, obviously it complains 
> that license text files aren't in the places the reuse tool wants them 
> to be and that's unimportant, but it does highlight some other low 
> hanging fruit:
> 
> * The following are missing SPDX headers:
> 
>      * scripts/lib/devtool/menuconfig.py
>      * meta-skeleton/recipes-kernel/hello-mod/files/hello.c
> 
> * The following are missing copyright headers:
> 
>      * scripts/lib/argparse_oe.py
>      * scripts/lib/wic/plugins/source/bootimg-partition.py
>      * scripts/lib/wic/plugins/source/empty.py
>      * scripts/lib/wic/plugins/source/isoimage-isohybrid.py
>      * scripts/lib/wic/plugins/source/rawcopy.py


I've tweaked the patches to cover those, thanks.

> * Most files under meta/conf can probaby have copyright and license 
> headers added without any confusion.

Yes, I'd agree.

> * `reuse lint` will accept the following header as valid, which could be 
> a path forward for recipes if other folks think it's clear enough:
> 
>      # Recipe: Copyright OpenEmbedded Contributors
>      # Recipe: SPDX-License-Identifier: MIT

Certainly worth considering.

Cheers,

Richard