From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDF8EC02180 for ; Thu, 16 Jan 2025 08:33:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YYbjq3vqBz3cds for ; Thu, 16 Jan 2025 19:33:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=115.124.30.98 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737016413; cv=none; b=mJJgd6fCNkTznaupqoZYvybvtLj50Bo0sY4/Gk4wM5V/b91Esd2MlJ9k84APST/asn3IT5HHR1U5XjjpsbGrLVKYqEXthsS7nHREg6h1Wx9wTd77BtxK7DWO+HoGxIR6RNXHriIuXmN6+6aoiKaNI07hC4Y3Us6WGPbgnbSQc0rL/MsdX8rSdIEPX5SHftxXOlgmlPgbI63vpa4LQWLSbLQrYsJJhspK81RT8MFIGodBKmCGdI/f0orYdg8V62RvbhUdpkPtqFR4QWGFfWX7qbSdaQzSwvtJhOCdF4tGQG0FsBMMdGXZ4ygYSvdhIVhb5nOp5uEOLM120/vL3Q5f9A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737016413; c=relaxed/relaxed; bh=PHfQkkB55ebGdxpOI6zf43XLyTVnn+B5ouE5AZYqxj8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gDzUhyxICuXAB8asF0+BxxoFUSVkF1jLiOrS41b7TjKXeY8w+Ca45YDnzTiD2DkRc94jtrlh4E0LQwCgeK6RAvIUCw0w2i6aYIK0KnK9ZjCeo6YckzY9FBtxMFC4aOC0MsgIqgwUHy6HrhfmHILTn4NNJXzBOY1gJ7wtHnTBx0A2ucqcZ6Cj3pHTIh7oOnq4lGKHFKX3iaXl86M+TfzyxikYwg0JVNeQGYrGXnsPnxaOEw4yk4xJS6kytPqlZMjXGFHhT371JgWoyGEVe3zC69Z8JGcC8FBF+flSftJPNyoB6BAq4wI/WkUBTCBK0c9srUOWqFFUqt7DPRwYNPW5mQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=pFjlOeJ2; dkim-atps=neutral; spf=pass (client-ip=115.124.30.98; helo=out30-98.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.a=rsa-sha256 header.s=default header.b=pFjlOeJ2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.alibaba.com (client-ip=115.124.30.98; helo=out30-98.freemail.mail.aliyun.com; envelope-from=hsiangkao@linux.alibaba.com; receiver=lists.ozlabs.org) Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YYbjm40kXz2ysc for ; Thu, 16 Jan 2025 19:33:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1737016407; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=PHfQkkB55ebGdxpOI6zf43XLyTVnn+B5ouE5AZYqxj8=; b=pFjlOeJ2wQuowjPEunvaIRbe5T/UHvFjYo7Q5q1dScKzS7MUCmxzvLBoWY4Vs0UR6/94M3omQjbOOmuHo1w9heTGC+e8eEdj3Da17C64vdu4o3dVpiMkIA0ouJgUn0l8olE94XQR5lU1IBKOFpEbOPrBq27iaQPpXXcXMc1/WZA= Received: from 30.221.130.221(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WNl7TR5_1737016405 cluster:ay36) by smtp.aliyun-inc.com; Thu, 16 Jan 2025 16:33:26 +0800 Message-ID: Date: Thu, 16 Jan 2025 16:33:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan() To: Chao Yu , linux-erofs@lists.ozlabs.org References: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> <11ffcd03-c3ce-4d2b-8360-1968092f72c1@kernel.org> From: Gao Xiang In-Reply-To: <11ffcd03-c3ce-4d2b-8360-1968092f72c1@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2025/1/16 16:31, Chao Yu wrote: > On 1/14/25 12:00, Gao Xiang wrote: >> z_erofs_shrink_scan() could return small numbers due to the mistyped >> `freed`. >> >> Although I don't think it has any visible impact. > > Agreed, it's an extreme case... Yeah... also thanks for the review. Thanks, Gao Xiang