From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
andy.shevchenko@gmail.com, jonathanh@nvidia.com,
ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
thierry.reding@gmail.com
Subject: Re: [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq
Date: Fri, 10 Dec 2021 01:27:55 +0300 [thread overview]
Message-ID: <c9eceaba-df4e-0e75-d6a7-87cfdf45fced@gmail.com> (raw)
In-Reply-To: <1639067318-29014-1-git-send-email-akhilrajeev@nvidia.com>
09.12.2021 19:28, Akhil R пишет:
> - err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
> - &i2c_dev->bus_clk_rate);
> - if (err)
> - i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
> + i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);
Was this patch tested at all? Apparently it wasn't compile-tested.
drivers/i2c/busses/i2c-tegra.c: In function ‘tegra_i2c_parse_dt’:
drivers/i2c/busses/i2c-tegra.c:1635:13: warning: unused variable ‘err’ [-Wunused-variable]
1635 | int err;
BTW, MM, DRI and media mailing lists have nothing to do with this patch
next prev parent reply other threads:[~2021-12-09 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 16:28 [PATCH v2] i2c: tegra: use i2c_timings for bus clock freq Akhil R
2021-12-09 16:28 ` Akhil R
2021-12-09 22:27 ` Dmitry Osipenko [this message]
2021-12-10 6:43 ` Akhil R
2021-12-10 8:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9eceaba-df4e-0e75-d6a7-87cfdf45fced@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.