From: Can Guo <cang@codeaurora.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, Jaegeuk Kim <jaegeuk@google.com>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: Re: [PATCH 4/4] scsi: add more contexts in the ufs tracepoints
Date: Tue, 20 Oct 2020 20:33:17 +0800 [thread overview]
Message-ID: <c9eeaa283f4eafdd0dece7f4f8961aa5@codeaurora.org> (raw)
In-Reply-To: <8170ddc084fc40a57c51501cbc29f5ea@codeaurora.org>
On 2020-10-20 19:57, Can Guo wrote:
> On 2020-10-20 19:02, Can Guo wrote:
>> On 2020-10-20 18:51, Avri Altman wrote:
>>>>
>>>> On 2020-10-06 06:36, Jaegeuk Kim wrote:
>>>> > From: Jaegeuk Kim <jaegeuk@google.com>
>>>> >
>>>> > This adds user-friendly tracepoints with group id.
>>> You have the entire cdb as part of the upiu trace,
>>> Can't you parse what you need from there?
>>>
>>> Thanks,
>>> Avri
>>
>> Yes, but assume we have a large trace log file, having a
>> groud id allows us to filter the data by it easily, right?
>>
>> Thanks,
>>
>> Can Guo.
>
> I just dobule checked WRITE(10)'s CDB, byte 6 has group
> ID ONLY. So Avri is right, we don't even need to parse it,
> we can easily filter a ftrace log file by byte 6 to get the
> WRITE(10) cmds with specific group ID - we don't need this
> change.
>
> Thanks,
>
> Can Guo.
Please ignore my previous mail, I misunderstood the change. :(
You have my reivewed-by tag for this change.
Regards,
Can Guo.
next prev parent reply other threads:[~2020-10-20 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 22:36 [PATCH 1/4] scsi: ufs: atomic update for clkgating_enable Jaegeuk Kim
2020-10-05 22:36 ` [PATCH 2/4] scsi: ufs: clear UAC for FFU and RPMB LUNs Jaegeuk Kim
2020-10-20 2:17 ` Can Guo
2020-10-20 18:36 ` jaegeuk
2020-10-05 22:36 ` [PATCH 3/4] scsi: ufs: use WQ_HIGHPRI for gating work Jaegeuk Kim
2020-10-20 2:19 ` Can Guo
2020-10-20 18:27 ` jaegeuk
2020-10-05 22:36 ` [PATCH 4/4] scsi: add more contexts in the ufs tracepoints Jaegeuk Kim
2020-10-20 2:18 ` Can Guo
2020-10-20 10:51 ` Avri Altman
2020-10-20 11:02 ` Can Guo
2020-10-20 11:54 ` Avri Altman
2020-10-20 11:57 ` Can Guo
2020-10-20 12:33 ` Can Guo [this message]
2020-10-20 2:30 ` [PATCH 1/4] scsi: ufs: atomic update for clkgating_enable Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9eeaa283f4eafdd0dece7f4f8961aa5@codeaurora.org \
--to=cang@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=jaegeuk@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.