From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Menglong Dong <menglong8.dong@gmail.com>
Subject: Re: [PATCH net-next] skb: make drop reason booleanable
Date: Fri, 4 Mar 2022 08:31:00 -0700 [thread overview]
Message-ID: <c9f81dc8-d32c-4ce1-5963-a45bc72fcd31@gmail.com> (raw)
In-Reply-To: <CANn89iJ_06Tz8qA26JsgG14XdHCcDbK91MCYqneygSuTRdzsDg@mail.gmail.com>
On 3/3/22 11:37 PM, Eric Dumazet wrote:
> On Thu, Mar 3, 2022 at 9:22 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Thu, 3 Mar 2022 20:53:53 -0800 Jakub Kicinski wrote:
>>> - return false;
>>> + return __SKB_OKAY;
>>
>> s/__//
>>
>> I'll send a v2 if I get acks / positive feedback.
>
>
> I am not a big fan of SKB_OKAY ?
>
> Maybe SKB_NOT_DROPPED_YET, or SKB_VALID_SO_FAR.
>
> Oh well, I am not good at names.
SKB_DROP_EXPECTED or SKB_DROP_NORMAL? That said I thought consume_skb is
for normal, release path and then kfree_skb is when an skb is dropped
for unexpected reasons.
next prev parent reply other threads:[~2022-03-04 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 4:53 [PATCH net-next] skb: make drop reason booleanable Jakub Kicinski
2022-03-04 5:22 ` Jakub Kicinski
2022-03-04 6:37 ` Eric Dumazet
2022-03-04 15:31 ` David Ahern [this message]
2022-03-04 16:36 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2022-03-08 0:44 Jakub Kicinski
2022-03-08 13:57 ` Toke Høiland-Jørgensen
2022-03-08 16:35 ` David Ahern
2022-03-09 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f81dc8-d32c-4ce1-5963-a45bc72fcd31@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.