Re: [PATCH 1/1] LoongArch: mm: remove redundant pte occupancy check in __set_fixmap()

[Yanteng Si <si.yanteng@linux.dev>]

在 5/8/25 11:05 AM, george 写道:
> From: George Guo <guodongtai@kylinos.cn>
This is unnecessary. Please remove it.

Thanks,
Yanteng
> 
> This check could falsely report errors when PTEs are remapped:
> arch/loongarch/mm/init.c:204: bad pte 0000000107b601c3.
> 
> The check was unnecessary because:
> - Fixmap slots are designed to be reusable
> - Other architectures (x86/arm64) allow PTE overwrites
> - Callers are responsible for proper mapping management
> 
> Signed-off-by: George Guo <guodongtai@kylinos.cn>
> ---
>   arch/loongarch/mm/init.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c
> index 06f11d9e4ec1..7b7e3b1aa00d 100644
> --- a/arch/loongarch/mm/init.c
> +++ b/arch/loongarch/mm/init.c
> @@ -200,10 +200,6 @@ void __init __set_fixmap(enum fixed_addresses idx,
>   	BUG_ON(idx <= FIX_HOLE || idx >= __end_of_fixed_addresses);
>   
>   	ptep = populate_kernel_pte(addr);
> -	if (!pte_none(ptep_get(ptep))) {
> -		pte_ERROR(*ptep);
> -		return;
> -	}
>   
>   	if (pgprot_val(flags))
>   		set_pte(ptep, pfn_pte(phys >> PAGE_SHIFT, flags));