From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JLVAh-0001si-RL for mharc-grub-devel@gnu.org; Sat, 02 Feb 2008 22:05:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JLVAg-0001sU-HM for grub-devel@gnu.org; Sat, 02 Feb 2008 22:05:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JLVAf-0001sF-43 for grub-devel@gnu.org; Sat, 02 Feb 2008 22:05:30 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JLVAe-0001sC-Ty for grub-devel@gnu.org; Sat, 02 Feb 2008 22:05:28 -0500 Received: from ti-out-0910.google.com ([209.85.142.188]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JLVAe-0001PU-9k for grub-devel@gnu.org; Sat, 02 Feb 2008 22:05:28 -0500 Received: by ti-out-0910.google.com with SMTP id a20so44829tia.10 for ; Sat, 02 Feb 2008 19:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=Lh+UYrar9Gz8T29ER7ICSl7h/18JcrhxlNkdb9n6/pU=; b=nUb8wUpEYrNKweEJlZOO1CX+xdT/yCr+cWzAwI/yAuReorhdKA/7qBRcvmp3NqFlBtVOtlaSeHH5kpo1GsxqWc0wN9wsMmXg/yb47h2fevvvEY1rCJYFemKxZRUMt0JEYTvWuXNlQccOK+J2kc5/9eTNfE+T/cSxMR+jicA9Zjw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WeVE7lVn08u9QIG9rxgBEMbiCsIBe4yYsuehv5djOJnw2unzi/WQBNfIkUjHI0CpUNrLSbVGzw/p9i6EPGS76DU2DNI9LmAdrt7eicWd0oTm3BVun/Y0K3C4eiNIFlvQ0G/zap8gyBLRk8JA28NHCbwZVvRm7Br9EnSmJ7MlTbc= Received: by 10.110.2.2 with SMTP id 2mr2754600tib.14.1202007926423; Sat, 02 Feb 2008 19:05:26 -0800 (PST) Received: by 10.110.62.19 with HTTP; Sat, 2 Feb 2008 19:05:26 -0800 (PST) Message-ID: Date: Sun, 3 Feb 2008 11:05:26 +0800 From: Bean To: "The development of GRUB 2" In-Reply-To: <20080202210714.GA7593@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080202204400.GA346@thorin> <87r6fvcbw2.fsf@xs4all.nl> <20080202210714.GA7593@thorin> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: grub.cfg parser still doesn't abort on error X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Feb 2008 03:05:30 -0000 On Feb 3, 2008 5:07 AM, Robert Millan wrote: > On Sat, Feb 02, 2008 at 09:59:57PM +0100, Marco Gerards wrote: > > Robert Millan writes: > > > > > Try the following grub.cfg: > > > > > > cat (memdisk)/non-existant-file > > > echo this point should never be reached > > > read > > > > > > You'll see that the echo is reached, even if cat returned an error. > > > > > > This becomes much worse when found in situations like: > > > > > > font (xxx)/some-file.pff > > > terminal gfxterm > > > > > > and the font wasn't loaded. > > > > Urgh! Bean committed a patch that zero'ed the error. Perhaps it was > > wrong? ;-) > > > > Can you try reverting it? :-) > > Actually, it was wrong before that. i think you can use the if statement to test command result. -- Bean