From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQOFf-00078T-K2 for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 11:15:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQOFe-00076e-0K for grub-devel@gnu.org; Tue, 05 Aug 2008 11:15:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQOFc-00074N-Du for grub-devel@gnu.org; Tue, 05 Aug 2008 11:15:05 -0400 Received: from [199.232.76.173] (port=41717 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQOFb-000748-Sy for grub-devel@gnu.org; Tue, 05 Aug 2008 11:15:03 -0400 Received: from ti-out-0910.google.com ([209.85.142.187]:38110) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQOFb-0006Xc-DE for grub-devel@gnu.org; Tue, 05 Aug 2008 11:15:03 -0400 Received: by ti-out-0910.google.com with SMTP id u5so727761tia.10 for ; Tue, 05 Aug 2008 08:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=okqDNrb5lkOzyV0FdjmOCu6iz7iDa6EzhjnMZW758kY=; b=xt9lRs6eYEaBghThYv7Mjfouejx6C/NTukthFsAmD9+302euRlfPnPgzXU6VL7qDYp xEK0k9AW1siuYlc/2zufwBe717CNXzssX1SQs5Pr/8bSeGrW0g45PMP24H2IC9+k7v8a NSqvNkAiudyzLNbYAueYjPiTSxmwPD59MziuM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Z1YOH9f1JFKINjQDo+N0Y6UVvEm2jqTk+eL4l8dPwNGeWz9e3l9uafvnB/UPFP/qRv UqIHaoJxnlV9km7EMQoAR5a4GAiu4rBt/e5zZ9NntqAe+FmT+I10qg4Tzj1oC3NCeM7t n/HPhHsW2bPlSeUsdmwGdjuc+/TE2qhfWPI2w= Received: by 10.110.105.10 with SMTP id d10mr1111368tic.52.1217949301476; Tue, 05 Aug 2008 08:15:01 -0700 (PDT) Received: by 10.110.16.5 with HTTP; Tue, 5 Aug 2008 08:15:01 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2008 23:15:01 +0800 From: Bean To: "The development of GRUB 2" In-Reply-To: <871w133mi2.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <87abfs32u9.fsf@xs4all.nl> <871w133mi2.fsf@xs4all.nl> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] PXE support for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 15:15:06 -0000 On Tue, Aug 5, 2008 at 4:16 PM, Marco Gerards wrote: > Bean writes: > >>>> +GRUB_MOD_INIT(pxe) >>>> +{ >>>> + (void) mod; /* To stop warning. */ >>>> + >>>> + grub_pxe_detect (); >>>> + if (grub_pxe_pxenv) >>>> + { >>>> + grub_disk_dev_register (&grub_pxe_dev); >>>> + grub_fs_register (&grub_pxefs_fs); >>> >>> filesystems belong in fs/ >> >> Perhaps I should place it in fs/i386/pc ? > > I think it would make things clearer, although I am not too sure :-) > >>>> +struct grub_pxenv >>>> +{ >>>> + grub_uint8_t signature[6]; /* 'PXENV+' */ >>>> + grub_uint16_t version; /* MSB = major, LSB = minor */ >>>> + grub_uint8_t length; /* structure length */ >>>> + grub_uint8_t checksum; /* checksum pad */ >>>> + grub_uint32_t rm_entry; /* SEG:OFF to PXE entry point */ >>>> + grub_uint32_t pm_offset; /* Protected mode entry */ >>>> + grub_uint16_t pm_selector; /* Protected mode selector */ >>>> + grub_uint16_t stack_seg; /* Stack segment address */ >>>> + grub_uint16_t stack_size; /* Stack segment size (bytes) */ >>>> + grub_uint16_t bc_code_seg; /* BC Code segment address */ >>>> + grub_uint16_t bc_code_size; /* BC Code segment size (bytes) */ >>>> + grub_uint16_t bc_data_seg; /* BC Data segment address */ >>>> + grub_uint16_t bc_data_size; /* BC Data segment size (bytes) */ >>>> + grub_uint16_t undi_data_seg; /* UNDI Data segment address */ >>>> + grub_uint16_t undi_data_size; /* UNDI Data segment size (bytes) */ >>>> + grub_uint16_t undi_code_seg; /* UNDI Code segment address */ >>>> + grub_uint16_t undi_code_size; /* UNDI Code segment size (bytes) */ >>>> + grub_uint32_t pxe_ptr; /* SEG:OFF to !PXE struct */ >>>> +} __attribute__ ((packed)); >>> >>> Can you GRUB-ify the comments here and below a bit? >> >> What do you mean by "GRUB-ify the comments" ? > > ". */ > > Although it is not too important for structs, I think :-) Fixed and committed. -- Bean