Re: [PATCH] Handler support

[Bean <bean123ch@gmail.com>]

On Sat, Feb 28, 2009 at 1:41 PM, Bean <bean123ch@gmail.com> wrote:
> On Sat, Feb 28, 2009 at 3:54 AM, Robert Millan <rmh@aybabtu.com> wrote:
>> On Sun, Feb 15, 2009 at 11:14:18PM +0800, Bean wrote:
>>> diff --git a/conf/sparc64-ieee1275.rmk b/conf/sparc64-ieee1275.rmk
>>> index 640ceda..18c108e 100644
>>> --- a/conf/sparc64-ieee1275.rmk
>>> +++ b/conf/sparc64-ieee1275.rmk
>>
>> Don't bother updating sparc64-ieee1275.rmk, it's completely broken by now.
>>
>>>  void
>>>  grub_term_register_input (grub_term_input_t term)
>>>  {
>>> -  term->next = grub_term_list_input;
>>> -  grub_term_list_input = term;
>>> -  if (! grub_cur_term_input)
>>> -    grub_term_set_current_input (term);
>>> +  grub_handler_register (&grub_term_input_class, GRUB_AS_HANDLER (term));
>>>  }
>>
>> Is grub_handler_register() always used this way?  Perhaps it should be
>> inline.
>
> Hi,
>
> Good point. In fact, I change all occurrence of
> grub_term_register_input to grub_handler_register previously, but
> considered the amount of code to change, I decide to provide the
> wrapper function grub_term_register_input. Using inline function would
> utilize the new handler infrastructure while retaining code
> compatibility.

Hi,

Fixed and committed.

-- 
Bean