Re: [PATCH 3/3] fio: server: Warn when listening on network

[Jens Axboe <axboe@kernel.dk>]

On 9/17/26 1:41 PM, Eric Sandeen wrote:
> Make it crystal clear to users at run time that the client/server
> protocol should only be used in trusted environments.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>  server.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/server.c b/server.c
> index 34f3f5c0..887ed7ed 100644
> --- a/server.c
> +++ b/server.c
> @@ -2596,6 +2596,13 @@ static int fio_init_server_connection(void)
>  	} else
>  		snprintf(bind_str, sizeof(bind_str), "%s", bind_sock);
>  
> +	if (!bind_sock) {
> +		log_info("fio: WARNING: The fio network protocol is neither "
> +			 "authenticated nor encrypted.\n");
> +		log_info("fio: WARNING: Use this mode only in trusted "
> +			 "environments.\n");
> +	}
> +
>  	log_info("fio: server listening on %s\n", bind_str);
>  
>  	if (listen(sk, 4) < 0) {

Let's not pollute the log with that - just document it in the...
documentation!

Like I said in a private email, anyone that runs a fio backend
outside of a trusted local/test environment needs to get their
head examined. By definition, since it's generally used to open
block devices and read/write to them it's run as root. And since
the environment should be trusted, so should the clients. Anyone
thinking otherwise needs to get their head examined.

-- 
Jens Axboe