Re: [PATCH linux v1 0/8] drivers: fsi: interrupt polling, i2c client

[eajames <eajames@linux.vnet.ibm.com>]

On 2017-02-02 18:55, Joel Stanley wrote:
> On Fri, Feb 3, 2017 at 9:55 AM,  <eajames@linux.vnet.ibm.com> wrote:
>> From: "Edward A. James" <eajames@us.ibm.com>
>> 
>> First, this series add interrupt polling support to the FSI bus 
>> driver.
>> This implements a loop that constantly polls the FSI slave interrupt
>> status register and triggers any registered client interrupt handlers 
>> upon
>> detecting an interrupt.
>> 
>> Secondly, this series adds the I2C client driver for FSI bus. This 
>> driver
>> interacts with the IBM BOE engine on an FSI slave device.
>> 
>> Christopher Bostic (3):
>>   drivers/fsi: Add slave interrupt polling
>>   drivers/fsi: Add Client IRQ Enable / Disable
>>   drivers/fsi: Add sysfs file to adjust i-poll period
>> 
>> Edward A. James (5):
>>   drivers: fsi: Add i2c client driver
>>   drivers: fsi: i2c: Add engine access wrappers
>>   drivers: fsi: i2c: probe fsi device for i2c client
>>   drivers: fsi: i2c: add driver file operations and bus locking
>>   drivers: fsi: i2c: boe engine
> 
> This series was a bit of a mess. The second 5 patches all had trailing
> whitespace. They didn't build cleanly. These patches had different
> subject prefxies too. You can generate the subject line like this:
> 
> git format-patch --subject-prefix "PATCH linux dev-4.7" and it will
> spit out patch files with the same subject prefix on all patches.
> 
> If you're doing v2, you can do:
> 
> git format-patch -v 2  --subject-prefix "PATCH linux dev-4.7" and it
> will add the v2 or v3 or v100 to your subject line.
> 
> The full incarnation might look like this:
> 
> git format-patch -v 2  --subject-prefix "PATCH linux dev-4.7"
> --to=joel@jms.id.au --cc=openbmc@lists.ozlabs.org origin/dev-4.7 -o
> fsi-patches-v2
> 
> And then once you've edited the cover letter, I do this:
> 
> git send-email fsi-patches-v2/*
> 
> I fixed the mess this time, but please make sure you're sending
> patches that cleanly apply and don't introduce warnings next time.
> 
> Cheers,
> 
> Joel

Thanks Joel, my apologies for the dirty patch set. I spent no effort 
cleaning anything up from the FSP code since this is a temporary 
measure. As for the subject prefixes, Chris generated the first three 
and I generated the last 5, so I didn't realize they had different 
subjects before I sent them out. Won't happen again. Looking forward to 
working on the new i2c driver.

Thanks,
Eddie

> 
>> 
>>  drivers/fsi/Kconfig           |    6 +
>>  drivers/fsi/Makefile          |    1 +
>>  drivers/fsi/fsi-core.c        |  170 +++
>>  drivers/fsi/fsi-master-gpio.c |    1 +
>>  drivers/fsi/fsi-master.h      |    2 +
>>  drivers/fsi/i2c/Makefile      |    1 +
>>  drivers/fsi/i2c/iic-boe.c     | 1597 +++++++++++++++++++++++++++++
>>  drivers/fsi/i2c/iic-boe.h     |  180 ++++
>>  drivers/fsi/i2c/iic-fsi.c     |  715 +++++++++++++
>>  drivers/fsi/i2c/iic-int.h     |  395 +++++++
>>  drivers/fsi/i2c/iic-lock.c    |  439 ++++++++
>>  drivers/fsi/i2c/iic-mstr.c    | 2281 
>> +++++++++++++++++++++++++++++++++++++++++
>>  include/linux/fsi.h           |    5 +
>>  include/uapi/linux/Kbuild     |    1 +
>>  include/uapi/linux/i2cfsi.h   |  136 +++
>>  15 files changed, 5930 insertions(+)
>>  create mode 100644 drivers/fsi/i2c/Makefile
>>  create mode 100644 drivers/fsi/i2c/iic-boe.c
>>  create mode 100644 drivers/fsi/i2c/iic-boe.h
>>  create mode 100644 drivers/fsi/i2c/iic-fsi.c
>>  create mode 100644 drivers/fsi/i2c/iic-int.h
>>  create mode 100644 drivers/fsi/i2c/iic-lock.c
>>  create mode 100644 drivers/fsi/i2c/iic-mstr.c
>>  create mode 100644 include/uapi/linux/i2cfsi.h
>> 
>> --
>> 1.8.3.1
>>