From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jae.hyun.yoo@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46NzpP6kWLzDqc9 for ; Thu, 5 Sep 2019 09:01:33 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 16:01:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,468,1559545200"; d="scan'208";a="194887411" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.148]) ([10.7.153.148]) by orsmga002.jf.intel.com with ESMTP; 04 Sep 2019 16:01:30 -0700 Subject: Re: [PATCH dev-5.2 0/2] i2c: aspeed: Add H/W timeout support To: Joel Stanley Cc: Ryan Chen , Andrew Jeffery , OpenBMC Maillist , Brendan Higgins , Tao Ren References: <20190904200758.5420-1-jae.hyun.yoo@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Wed, 4 Sep 2019 16:01:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 23:01:35 -0000 Hi Joel, On 9/4/2019 3:54 PM, Joel Stanley wrote: > Hi Jae, > > On Wed, 4 Sep 2019 at 20:08, Jae Hyun Yoo wrote: >> >> In case of multi-master environment, if a peer master incorrectly handles >> a bus in the middle of a transaction, I2C hardware hangs in slave state >> and it can't escape from the slave state, so this commit adds slave >> inactive timeout support to recover the bus in the case. >> >> By applying this change, SDA data-low and SCL clock-low timeout feature >> also could be enabled which was disabled previously. > > Please consider sending your RFC patches to the upstream list. You > have a big backlog of patches now. Thanks for the reminding. I can't send the RFC patches yet because QEMU H/W model isn't ready yet. I'm still waiting for the fix from Cedric. Thanks, Jae > > Cheers, > > Joel > >> >> Jae Hyun Yoo (2): >> dt-bindings: i2c: aspeed: add hardware timeout support >> i2c: aspeed: add slave inactive timeout support >> >> .../devicetree/bindings/i2c/i2c-aspeed.txt | 2 + >> drivers/i2c/busses/i2c-aspeed.c | 79 +++++++++++++++++-- >> 2 files changed, 75 insertions(+), 6 deletions(-) >> >> -- >> 2.23.0 >>