From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH] drm/tegra: Add zpos property for cursor planes Date: Wed, 10 Jun 2020 16:16:14 +0300 Message-ID: References: <20200610113059.2164132-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200610113059.2164132-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jon Hunter List-Id: linux-tegra@vger.kernel.org 10.06.2020 14:30, Thierry Reding пишет: > From: Thierry Reding > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > have a zpos property") a warning is emitted if there's a mix of planes > with and without a zpos property. > > On Tegra, cursor planes are always composited on top of all other > planes, which is why they never had a zpos property attached to them. > However, since the composition order is fixed, this is trivial to > remedy by simply attaching an immutable zpos property to them. > > Reported-by: Jonathan Hunter > Signed-off-by: Thierry Reding > --- What problem does it solve? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC2CC433E1 for ; Thu, 11 Jun 2020 07:54:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE1D520814 for ; Thu, 11 Jun 2020 07:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dklUVQIg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE1D520814 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E045B6E8A1; Thu, 11 Jun 2020 07:54:03 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38FAF6E119 for ; Wed, 10 Jun 2020 13:16:17 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id w15so1413840lfe.11 for ; Wed, 10 Jun 2020 06:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OXsw15cR+ZyosRfP5eToOJ+Kwm4SVk27QffhyUka7K4=; b=dklUVQIg0cT3POJq7VrrAhoxRlIBa2SLaAudlZk3GM2eJlmoCjen9saRJxYNj0cAih qkpNPi9TdjjWYjgkRYNF1qXExXURZgzmJt7q1qid+R6s8NfOU/wV7jEBciopsf0RRb+P VPuz6a8feC10FRIAEMC/mPnPzKO00Lf3b/RV3yehxe5qEd0Dgo2SEk15IxalksGB3elW CAZbEP/AzFyfojJ/LxQmtWIlkf563ahMSvjB/RAtxuqmoASw0dTBVQgINEenaYWFiB36 VmWIND4olOFaOtuODEtSN88BC6VIrwyUSOC93ESyXNBWEvO0VZgqrYNQfGkYM0nMH6QT LTdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OXsw15cR+ZyosRfP5eToOJ+Kwm4SVk27QffhyUka7K4=; b=TmfMJU/MpcCW67Ae0reO2CwlJKMbxkhRLng+W3Jdr/z/lilzp2Ox4v6EGdsoey/yU4 Mngz5xLoSiq9FtGf9MgaGpZxm+M3WYb3cS01diEnH/Ak4hO5xY+7/gKdSUEA6JH4yjHP rfh+wP7AE5TmrHqnZk+j0sDZzGoTBResYl918AJBHKA+O8j8c7sHQe/FIbPiRJw9ptEO Ugp98OUXunTH1rX2X42rJd6MQTvfJEtx2QCh/drbfS0a1nQVHC/xF6FVyd90xvisMl2t w5vUCl+hlHcyCtw1a1jcopWrQrBdNoInZDKs0AZuSmaItYlpuqmb9pHM6cRLDVKCNMXO dLVQ== X-Gm-Message-State: AOAM531WQhV+23KOpFZpgmQxF3v78HDBDHLB0JAvheYRdrWFEtl8DLbq Yew+twaMemRfbRj4Y25GwG0= X-Google-Smtp-Source: ABdhPJwAPrv2z4RRmB7XqNuKaIm0bk8kY6kw8F3Rh9nxZRK38Jk0ohshYLm/22qpCPoyJSAwGeImsw== X-Received: by 2002:ac2:5cd1:: with SMTP id f17mr1631899lfq.4.1591794975611; Wed, 10 Jun 2020 06:16:15 -0700 (PDT) Received: from [192.168.2.145] (79-139-237-54.dynamic.spd-mgts.ru. [79.139.237.54]) by smtp.googlemail.com with ESMTPSA id g12sm5001549ljl.33.2020.06.10.06.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2020 06:16:15 -0700 (PDT) Subject: Re: [PATCH] drm/tegra: Add zpos property for cursor planes To: Thierry Reding References: <20200610113059.2164132-1-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 10 Jun 2020 16:16:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200610113059.2164132-1-thierry.reding@gmail.com> Content-Language: en-US X-Mailman-Approved-At: Thu, 11 Jun 2020 07:54:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, Jon Hunter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MTAuMDYuMjAyMCAxNDozMCwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKPiBGcm9tOiBUaGll cnJ5IFJlZGluZyA8dHJlZGluZ0BudmlkaWEuY29tPgo+IAo+IEFzIG9mIGNvbW1pdCA0ZGM1NTUy NWIwOTUgKCJkcm06IHBsYW5lOiBWZXJpZnkgdGhhdCBubyBvciBhbGwgcGxhbmVzCj4gaGF2ZSBh IHpwb3MgcHJvcGVydHkiKSBhIHdhcm5pbmcgaXMgZW1pdHRlZCBpZiB0aGVyZSdzIGEgbWl4IG9m IHBsYW5lcwo+IHdpdGggYW5kIHdpdGhvdXQgYSB6cG9zIHByb3BlcnR5Lgo+IAo+IE9uIFRlZ3Jh LCBjdXJzb3IgcGxhbmVzIGFyZSBhbHdheXMgY29tcG9zaXRlZCBvbiB0b3Agb2YgYWxsIG90aGVy Cj4gcGxhbmVzLCB3aGljaCBpcyB3aHkgdGhleSBuZXZlciBoYWQgYSB6cG9zIHByb3BlcnR5IGF0 dGFjaGVkIHRvIHRoZW0uCj4gSG93ZXZlciwgc2luY2UgdGhlIGNvbXBvc2l0aW9uIG9yZGVyIGlz IGZpeGVkLCB0aGlzIGlzIHRyaXZpYWwgdG8KPiByZW1lZHkgYnkgc2ltcGx5IGF0dGFjaGluZyBh biBpbW11dGFibGUgenBvcyBwcm9wZXJ0eSB0byB0aGVtLgo+IAo+IFJlcG9ydGVkLWJ5OiBKb25h dGhhbiBIdW50ZXIgPGpvbmF0aGFuaEBudmlkaWEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFRoaWVy cnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gLS0tCgpXaGF0IHByb2JsZW0gZG9lcyBp dCBzb2x2ZT8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=