Re: [RESEND RFC PATCH 08/12] mfd/sm501: Add OF properties.

[Krzysztof Kozlowski <krzk@kernel.org>]

On 31/08/2023 03:11, Yoshinori Sato wrote:
> Some parameters only platform_device.
> Added same parameters in OF property.

Subject: everything can be "add of properties". Is some next commit
adding properties to this file going to have the same subject? Please
write subjects matching changes.


> 
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  .../devicetree/bindings/display/sm501fb.txt   |  11 ++
>  drivers/mfd/sm501.c                           | 113 +++++++++++++++++-

Nope, bindings are never mixed with drivers.

And you clearly did not run checkpatch, so:

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.


>  2 files changed, 123 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/sm501fb.txt b/Documentation/devicetree/bindings/display/sm501fb.txt
> index 1c79c267a57f..4c4920394431 100644
> --- a/Documentation/devicetree/bindings/display/sm501fb.txt
> +++ b/Documentation/devicetree/bindings/display/sm501fb.txt
> @@ -20,6 +20,17 @@ Optional properties:
>    set different foreign endian.
>  - big-endian: available on little endian systems, to
>    set different foreign endian.
> +- sm501,devices: select peripheral functions.
> +  available usb-host, usb-gadget, ssp0, ssp,1 uart0, uart1, accel,
> +            ac97, i2s, gpio and all.
> +- sm501,mclk: SM501 mclk frequency.
> +- sm501,m1xclk: SM501 m1xclk frequency.
> +- sm501,misc-timing: SM501 Miscellaneous Timing reg value.
> +- sm501,misc-control: SM501 Miscellaneous Control reg value.
> +- sm501,gpio-low: SM501 GPIO31-0 Control reg value.
> +- sm501,gpio-high: SM501 GPIO63-32 Control reg value.
> +- sm501,num-i2c: I2C channel number.
> +- sm501,gpio-i2c: I2C assigned GPIO.

Sorry, new properties are allowed only in DT schema format. Convert
bindings to DT schema first.


Best regards,
Krzysztof