From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 833B4C83F09 for ; Wed, 9 Jul 2025 06:50:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1037735.1410273 (Exim 4.92) (envelope-from ) id 1uZOd4-0007xD-BF; Wed, 09 Jul 2025 06:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1037735.1410273; Wed, 09 Jul 2025 06:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uZOd4-0007x6-7L; Wed, 09 Jul 2025 06:50:06 +0000 Received: by outflank-mailman (input) for mailman id 1037735; Wed, 09 Jul 2025 06:50:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uZOd3-0007lM-A9 for xen-devel@lists.xenproject.org; Wed, 09 Jul 2025 06:50:05 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f107d0d3-5c90-11f0-a317-13f23c93f187; Wed, 09 Jul 2025 08:50:04 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a503d9ef59so3916850f8f.3 for ; Tue, 08 Jul 2025 23:50:04 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c3006ee2esm1109139a91.18.2025.07.08.23.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 23:50:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f107d0d3-5c90-11f0-a317-13f23c93f187 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1752043803; x=1752648603; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Mms9PRv6OMNovEv77pMS8HDnUUMT96ymOm1YxCJExxg=; b=XerW+8AfnlvHxHV374m47wm++BE0kumDnfW30A1zup2VhKRHa/LIjITyoZfH/KegDw Jlw1jG1WeLs+DJiWv9fFXBDRFgvI1cLkJ0GcR8bo498tO4jNoyMRWWrqHhW8HAS0ApCA fmhf/dUj3laSFiHzUUKaVdi4hTWSzGlLNjSC5WtIfqcJgbDloMCJMCisVuCbbkSfG/Vn 0SmKfEtchsLpyWQvGQsPKWXPW5Ftg96Y+6uynZrCPLebXIN1/5jlekIBsU+UrmrtGxGn d4SiKHKCvL69PXTd6GNbpwb+QgcZc3gVLN8FlwHGLoPouC0KTIUtahBjTvnUIkksx/Mg IfJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043803; x=1752648603; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mms9PRv6OMNovEv77pMS8HDnUUMT96ymOm1YxCJExxg=; b=RBIuXN1D1975DTIQuxEYbgcDH6BtSm1/n6c7h+7bE5B/sbHhlcaWxzq5SOjj9gkS1p N47evgp21j8q3SbWZfduFQAsYO8Ob8kJzYO2iExHPrWX3pUeMAt/Tb+lDUha/CijjQWd wEAVE+Xlbt5OLbz5XYwocvLmDUptvUX1ueIET60uns0cyMlZ6neGZX5bFUWl87Dbvi/F y2Z8dAFuvSVlkXXFQuDQwG7JvJ5j5L9ufMzAZDc5yibIZ521frM7RhMc1mRA/lnGmOT0 XJmoRZg7ab3jcHQOG8++HelZtzHQ0HsRvbNoTvm22F7fnLeC3E4zozmU+9sWEyKXvr99 Rwhg== X-Forwarded-Encrypted: i=1; AJvYcCUfq0xVPx8yu2MpCYJtQlma9deee/vIshtlUw2UZfaR3E92ukmjtF5Yigw2o6NpbZTLjUSxFHajslE=@lists.xenproject.org X-Gm-Message-State: AOJu0Yzyju4pXCN9AstRW9ZjRICQFPDZYBtRUQSP8/W80px1sOMAK5w7 iDRuCU+i1VKxgK4V1D4MZqeHUOmkhPUsvEEPydFgztB8BBIJayDh/fOwt92JgzkjIg== X-Gm-Gg: ASbGncsRFm0z3jE54dtWjKJH1lLNO2QcHH57awfsf0qGd+7PJHhAi06UkmemknSyQM1 mutr6wzoMCS5GQhV+UDhCzrBC2Rk/uNmmgSd19lHeJo/ZxG4vDQ9LL3VypBg1COqX1XalmDlS7Y dekGqSbJQYMy9dochmOeaeCVQskTQrf59fBJP3Jiw+xpqeDOkOtZWvhjTa4FydYs/idmHAKrvST JlBYfWPu6FujJscAv6UiMi4I1xtHKs3irtIzrf5lcOEBxFkhKyhz5hH/+Q5xaQesNgH20ou0BYb m8X37f6iAWhy6oS0IrIeonDN8OhF1PytPSdCnK1NRZPU6aHwc/3mVZ93hcVt4VbWT/ntaPBLv9O lr1WCvh8O1rXPdjD9oh0JKpsK/gy1DfjRg8Y8EG9r0YqY+fc= X-Google-Smtp-Source: AGHT+IEuw7u1MHxon5uQVyrqid7msGanXXcjum+As6psdW7G2CfPfiHh1oIsUqx2bGg3/DVWyR6ZvQ== X-Received: by 2002:a05:6000:188f:b0:3a5:88cf:479e with SMTP id ffacd0b85a97d-3b5e455be71mr858336f8f.48.1752043803249; Tue, 08 Jul 2025 23:50:03 -0700 (PDT) Message-ID: Date: Wed, 9 Jul 2025 08:49:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 7/8] vpci/msi: Free MSI resources when init_msi() fails To: "Chen, Jiqian" Cc: "Huang, Ray" , "xen-devel@lists.xenproject.org" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20250704070803.314366-1-Jiqian.Chen@amd.com> <20250704070803.314366-8-Jiqian.Chen@amd.com> <83abcd7b-e742-4a0e-814f-1f2b801eaff9@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09.07.2025 08:10, Chen, Jiqian wrote: > On 2025/7/8 23:13, Jan Beulich wrote: >> On 04.07.2025 09:08, Jiqian Chen wrote: >>> @@ -193,6 +234,42 @@ static void cf_check mask_write( >>> msi->mask = val; >>> } >>> >>> +static int cf_check cleanup_msi(const struct pci_dev *pdev) >>> +{ >>> + int rc; >>> + unsigned int end; >>> + struct vpci *vpci = pdev->vpci; >>> + const unsigned int msi_pos = pdev->msi_pos; >>> + const unsigned int ctrl = msi_control_reg(msi_pos); >>> + >>> + if ( !msi_pos || !vpci->msi ) >>> + return 0; >>> + >>> + if ( vpci->msi->masking ) >>> + end = msi_pending_bits_reg(msi_pos, vpci->msi->address64); >>> + else >>> + end = msi_mask_bits_reg(msi_pos, vpci->msi->address64) - 2; >> >> What's this "- 2" for? If there's no masking support, you want to cut off >> _at_ the mask register, not 2 bytes ahead of it? Just like you cut off at >> the pending bits register when there is masking support. > "-2" here is to cut the reserved 2 bytes of Message Data if there is no masking support. Hmm, init_msi() doesn't intercept Extended Message Data when present. I think that's wrong there, leading to the oddity here. (Imo such use of hard coded numbers would almost always want to be accompanied by a comment.) Jan