From: Jiri Slaby <jirislaby@kernel.org>
To: liujing <liujing@cmss.chinamobile.com>, mpe@ellerman.id.au
Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu,
naveen@kernel.org, maddy@linux.ibm.com,
gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: hvc: Fix incorrect formatted output
Date: Thu, 7 Nov 2024 08:47:02 +0100 [thread overview]
Message-ID: <cacff0e1-e5fe-4e6e-afb5-ca18f3d9c93c@kernel.org> (raw)
In-Reply-To: <20241107073332.5483-1-liujing@cmss.chinamobile.com>
On 07. 11. 24, 8:33, liujing wrote:
> The termno parameter is defined as an unsigned int
> in hvc_opal_probe(), So the output format should be %u instead of %d.
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>
> ---
> v1 -> V2: Modified the description of commit.
>
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index 095c33ad10f8..1d2e7f2ce088 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -199,7 +199,7 @@ static int hvc_opal_probe(struct platform_device *dev)
> /* Instanciate now to establish a mapping index==vtermno */
> hvc_instantiate(termno, termno, ops);
> } else {
> - pr_err("hvc_opal: Device %pOF has duplicate terminal number #%d\n",
> + pr_err("hvc_opal: Device %pOF has duplicate terminal number #%u\n",
Please re-read my _whole_ previous e-mail.
--
js
suse labs
next prev parent reply other threads:[~2024-11-07 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 7:33 [PATCH] tty: hvc: Fix incorrect formatted output liujing
2024-11-07 7:47 ` Jiri Slaby [this message]
2024-11-07 7:47 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2024-11-07 5:47 [PATCH] tty:hvc:Fix " liujing
2024-11-07 7:10 ` Jiri Slaby
2024-11-07 7:11 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cacff0e1-e5fe-4e6e-afb5-ca18f3d9c93c@kernel.org \
--to=jirislaby@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liujing@cmss.chinamobile.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.