From: Chengming Zhou <chengming.zhou@linux.dev>
To: Sergey Senozhatsky <senozhatsky@chromium.org>, akpm@linux-foundation.org
Cc: minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts
Date: Fri, 28 Jun 2024 11:19:32 +0800 [thread overview]
Message-ID: <caf4b05d-6adf-4976-9961-fa30d3a9969c@linux.dev> (raw)
In-Reply-To: <20240628010812.GD15925@google.com>
On 2024/6/28 09:08, Sergey Senozhatsky wrote:
> On (24/06/28 09:55), Sergey Senozhatsky wrote:
>> We can land this patch, if you insist/prefer, but it's some sort of
>> a NOOP, essentially (in a sense that it has no visible effects).
>
> Forgot to mention, sorry. If we land this then I'll ask for a different
> commit message. "Fix" sounds alarming. It would be better to say something
> like "keep that stat counter accurate, but RATIO_O is never used anywhere".
You're right, "fix" sounds alarming although it's a fix, but it has no
any virtual effect. I just found it when I last time changed to the
per-class locking but forgot to send it.
Andrew, could you please help to change the subject as Sergey asked?
Sorry, I should have noted these details in the changelog when I wrote
this subject.
Thanks.
next prev parent reply other threads:[~2024-06-28 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 7:59 [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts Chengming Zhou
2024-06-27 7:59 ` [PATCH 2/2] mm/zsmalloc: move record_obj() into obj_malloc() Chengming Zhou
2024-06-28 2:25 ` Sergey Senozhatsky
2024-06-27 20:33 ` [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts Andrew Morton
2024-06-28 0:51 ` Sergey Senozhatsky
2024-06-28 0:55 ` Sergey Senozhatsky
2024-06-28 1:08 ` Sergey Senozhatsky
2024-06-28 3:19 ` Chengming Zhou [this message]
2024-07-01 1:37 ` Sergey Senozhatsky
2024-07-01 2:20 ` Chengming Zhou
2024-07-01 2:49 ` Chengming Zhou
2024-07-01 3:13 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf4b05d-6adf-4976-9961-fa30d3a9969c@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.