Re: [PATCH bpf-next] libbpf: fix build by renaming variables

[Prashant Bhole <prashantbhole.linux@gmail.com>]

On 12/16/19 11:02 PM, Alexei Starovoitov wrote:
> On Mon, Dec 16, 2019 at 5:25 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>>
>> On Mon, Dec 16, 2019 at 05:27:38PM +0900, Prashant Bhole wrote:
>>> In btf__align_of() variable name 't' is shadowed by inner block
>>> declaration of another variable with same name. Patch renames
>>> variables in order to fix it.
>>>
>>>    CC       sharedobjs/btf.o
>>> btf.c: In function ‘btf__align_of’:
>>> btf.c:303:21: error: declaration of ‘t’ shadows a previous local [-Werror=shadow]
>>>    303 |   int i, align = 1, t;
>>>        |                     ^
>>> btf.c:283:25: note: shadowed declaration is here
>>>    283 |  const struct btf_type *t = btf__type_by_id(btf, id);
>>>        |
>>>
>>> Fixes: 3d208f4ca111 ("libbpf: Expose btf__align_of() API")
>>> Signed-off-by: Prashant Bhole <prashantbhole.linux@gmail.com>
>>
>> Applied, thanks!
> 
> Prashant,
> Thanks for the fixes.
> Which compiler do use?

gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)

> Sadly I didn't see any of those with my gcc 6.3.0
> Going to upgrade it. Need to decide which one.
>