Re: [cocci] Can Coccinelle concatenate or append to existing string literals?

[Markus Elfring <Markus.Elfring@web.de>]

> to produce this:
>
> 	void f()
> 	{
> 	-	foo("foo");
> 	+	foo("foo_bar");
> 	}
>
> It looks like `fresh identifier` can do something like this,
> but I can't get it to work with strings.


I suggest to increase the distinction which data parts you would like to modify
for such a transformation attempt.



> Is there a way?


Will another test result for a SmPL script like the following trigger any further
collateral evolution?

@addition@
@@
 void f()
 {
 foo("foo"
+    "_bar"
    );
 }


Markus_Elfring@Sonne:…Projekte/Coccinelle/Probe> spatch --parse-cocci append_to_string_literal1.cocci
…
plus: parse error:
  File "append_to_string_literal1.cocci", line 6, column 10, charpos = 48
  around = '"',
  whole content = +    "_bar"


How will the chances evolve to support string literal concatenations better here
(by the means of the semantic patch language)?
https://en.cppreference.com/w/c/language/string_literal#Explanation


@initialize:python@
@@
import re

@find_update_candidate@
constant input_string;
position pos;
@@
 void f()
 {
 foo@pos(input_string);
 }

@script:python selection@
param << find_update_candidate.input_string;
text;
@@
if param == '"foo"':
   coccinelle.text = cocci.make_expr('"foo_bar"')
else:
   cocci.include_match(False)

@replacement@
constant find_update_candidate.input_string, selection.text;
position find_update_candidate.pos;
@@
 void f()
 {
 foo@pos(
-        input_string
+        text
        );
 }


Markus_Elfring@Sonne:…Projekte/Coccinelle/Probe> spatch append_to_string_literal2.cocci string_literal_usage1.c
…
@@ -1,4 +1,4 @@
 void f()
 {
-foo("foo");
+foo("foo_bar");
 }


Regards,
Markus