From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuehaibing Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure Date: Thu, 31 Oct 2019 21:33:38 +0800 Message-ID: References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , thierry.reding@gmail.com, mperttunen@nvidia.com, arnd@arndb.de, seanpaul@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 2019/10/31 6:26, Dmitry Osipenko wrote: > 30.10.2019 16:54, YueHaibing пишет: >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >> COMPILE_TEST is y, building fails: >> >> drivers/gpu/host1x/dev.o: In function `host1x_remove': >> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >> >> Reported-by: Hulk Robot >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >> Signed-off-by: YueHaibing >> --- >> drivers/gpu/host1x/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >> index cf987a3..354232d 100644 >> --- a/drivers/gpu/host1x/Kconfig >> +++ b/drivers/gpu/host1x/Kconfig >> @@ -2,7 +2,7 @@ >> config TEGRA_HOST1X >> tristate "NVIDIA Tegra host1x driver" >> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >> - select IOMMU_IOVA if IOMMU_SUPPORT >> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >> help >> Driver for the NVIDIA Tegra host1x hardware. >> >> > > It should be better to unconditionally select IOMMU_IOVA here. > > The same could be done for drivers/staging/media/tegra-vde/ and > drivers/gpu/host1x/, please see [1]. Yep, I will repost, thanks! > > [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/ > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB260CA9ECE for ; Fri, 1 Nov 2019 08:10:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6BA4208E3 for ; Fri, 1 Nov 2019 08:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6BA4208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DC2889FED; Fri, 1 Nov 2019 08:10:37 +0000 (UTC) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56E176EE8D for ; Thu, 31 Oct 2019 13:33:48 +0000 (UTC) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 59160C34EDB324E71694; Thu, 31 Oct 2019 21:33:44 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Thu, 31 Oct 2019 21:33:40 +0800 Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Dmitry Osipenko , , , , References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> From: Yuehaibing Message-ID: Date: Thu, 31 Oct 2019 21:33:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 01 Nov 2019 08:09:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191031133338.cjCJ9OD7yR39tY5kcvs1SpJZns-MLkEzRVL3BckcrSw@z> T24gMjAxOS8xMC8zMSA2OjI2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMzAuMTAuMjAxOSAx Njo1NCwgWXVlSGFpYmluZyDQv9C40YjQtdGCOgo+PiBJZiBJT01NVV9TVVBQT1JUIGlzIG5vdCBz ZXQsIGJ1dCBJT01NVV9JT1ZBIGlzIG0gYW5kCj4+IENPTVBJTEVfVEVTVCBpcyB5LCBidWlsZGlu ZyBmYWlsczoKPj4KPj4gZHJpdmVycy9ncHUvaG9zdDF4L2Rldi5vOiBJbiBmdW5jdGlvbiBgaG9z dDF4X3JlbW92ZSc6Cj4+IGRldi5jOigudGV4dCsweDYyNCk6IHVuZGVmaW5lZCByZWZlcmVuY2Ug dG8gYHB1dF9pb3ZhX2RvbWFpbicKPj4gZGV2LmM6KC50ZXh0KzB4NjI0KTogcmVsb2NhdGlvbiB0 cnVuY2F0ZWQgdG8gZml0OiBSX0FBUkNINjRfQ0FMTDI2IGFnYWluc3QgdW5kZWZpbmVkIHN5bWJv bCBgcHV0X2lvdmFfZG9tYWluJwo+PiBkZXYuYzooLnRleHQrMHg2MmMpOiB1bmRlZmluZWQgcmVm ZXJlbmNlIHRvIGBpb3ZhX2NhY2hlX3B1dCcKPj4gZGV2LmM6KC50ZXh0KzB4NjJjKTogcmVsb2Nh dGlvbiB0cnVuY2F0ZWQgdG8gZml0OiBSX0FBUkNINjRfQ0FMTDI2IGFnYWluc3QgdW5kZWZpbmVk IHN5bWJvbCBgaW92YV9jYWNoZV9wdXQnCj4+Cj4+IFNlbGVjdCBJT01NVV9JT1ZBIHdoaWxlIENP TVBJTEVfVEVTVCBpcyBzZXQgdG8gZml4IHRoaXMuCj4+Cj4+IFJlcG9ydGVkLWJ5OiBIdWxrIFJv Ym90IDxodWxrY2lAaHVhd2VpLmNvbT4KPj4gRml4ZXM6IDUyNDk5YTZhZDJhZSAoImdwdTogaG9z dDF4OiBzZWxlY3QgSU9NTVVfSU9WQSIpCj4+IFNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1 ZWhhaWJpbmdAaHVhd2VpLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZp ZyB8IDIgKy0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvaG9zdDF4L0tjb25maWcgYi9kcml2ZXJz L2dwdS9ob3N0MXgvS2NvbmZpZwo+PiBpbmRleCBjZjk4N2EzLi4zNTQyMzJkIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZpZwo+PiArKysgYi9kcml2ZXJzL2dwdS9ob3N0 MXgvS2NvbmZpZwo+PiBAQCAtMiw3ICsyLDcgQEAKPj4gIGNvbmZpZyBURUdSQV9IT1NUMVgKPj4g IAl0cmlzdGF0ZSAiTlZJRElBIFRlZ3JhIGhvc3QxeCBkcml2ZXIiCj4+ICAJZGVwZW5kcyBvbiBB UkNIX1RFR1JBIHx8IChBUk0gJiYgQ09NUElMRV9URVNUKQo+PiAtCXNlbGVjdCBJT01NVV9JT1ZB IGlmIElPTU1VX1NVUFBPUlQKPj4gKwlzZWxlY3QgSU9NTVVfSU9WQSBpZiAoSU9NTVVfU1VQUE9S VCB8fCBDT01QSUxFX1RFU1QpCj4+ICAJaGVscAo+PiAgCSAgRHJpdmVyIGZvciB0aGUgTlZJRElB IFRlZ3JhIGhvc3QxeCBoYXJkd2FyZS4KPj4gIAo+Pgo+IAo+IEl0IHNob3VsZCBiZSBiZXR0ZXIg dG8gdW5jb25kaXRpb25hbGx5IHNlbGVjdCBJT01NVV9JT1ZBIGhlcmUuCj4gCj4gVGhlIHNhbWUg Y291bGQgYmUgZG9uZSBmb3IgZHJpdmVycy9zdGFnaW5nL21lZGlhL3RlZ3JhLXZkZS8gYW5kCj4g ZHJpdmVycy9ncHUvaG9zdDF4LywgcGxlYXNlIHNlZSBbMV0uCgpZZXAsIEkgd2lsbCByZXBvc3Qs IHRoYW5rcyEKCj4gCj4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LWlvbW11LzIw MTkwODI5MTU0OTAyLkdDMTk4NDJAdWxtby8KPiAKPiAuCj4gCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D37CA9ECB for ; Thu, 31 Oct 2019 13:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F24EC20862 for ; Thu, 31 Oct 2019 13:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbfJaNdq (ORCPT ); Thu, 31 Oct 2019 09:33:46 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:43896 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726728AbfJaNdq (ORCPT ); Thu, 31 Oct 2019 09:33:46 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 59160C34EDB324E71694; Thu, 31 Oct 2019 21:33:44 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Thu, 31 Oct 2019 21:33:40 +0800 Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Dmitry Osipenko , , , , References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> CC: , , From: Yuehaibing Message-ID: Date: Thu, 31 Oct 2019 21:33:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/31 6:26, Dmitry Osipenko wrote: > 30.10.2019 16:54, YueHaibing пишет: >> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >> COMPILE_TEST is y, building fails: >> >> drivers/gpu/host1x/dev.o: In function `host1x_remove': >> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >> >> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >> >> Reported-by: Hulk Robot >> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >> Signed-off-by: YueHaibing >> --- >> drivers/gpu/host1x/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >> index cf987a3..354232d 100644 >> --- a/drivers/gpu/host1x/Kconfig >> +++ b/drivers/gpu/host1x/Kconfig >> @@ -2,7 +2,7 @@ >> config TEGRA_HOST1X >> tristate "NVIDIA Tegra host1x driver" >> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >> - select IOMMU_IOVA if IOMMU_SUPPORT >> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >> help >> Driver for the NVIDIA Tegra host1x hardware. >> >> > > It should be better to unconditionally select IOMMU_IOVA here. > > The same could be done for drivers/staging/media/tegra-vde/ and > drivers/gpu/host1x/, please see [1]. Yep, I will repost, thanks! > > [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/ > > . >