From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all
Date: Mon, 25 Feb 2019 10:38:02 -0800 [thread overview]
Message-ID: <cb2037d5-bd18-9f32-9330-eec295ad6d9b@intel.com> (raw)
In-Reply-To: <155111868966.15156.12967952244737771931@skylake-alporthouse-com>
On 25/02/19 10:18, Chris Wilson wrote:
> Quoting Ashutosh Dixit (2019-02-25 18:08:32)
>> igt@gem-exec-nop@signal-all runs a single uninterrupted loop for 150
>> sec. This results in the test being one of the longest execution times
>> in CI runs. For example:
>>
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5654/runtimes-iclb.txt
>>
>> Add a lighter version of the same test and include that in CI instead
>> to cut down the overall CI execution time.
>>
>> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>> ---
>> tests/i915/gem_exec_nop.c | 3 +++
>> tests/intel-ci/blacklist.txt | 2 +-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
>> index 59a08ad0..87ecd6c7 100644
>> --- a/tests/i915/gem_exec_nop.c
>> +++ b/tests/i915/gem_exec_nop.c
>> @@ -769,6 +769,9 @@ igt_main
>> igt_subtest("signal-all")
>> fence_signal(device, handle, ALL_ENGINES, "all", 150);
>>
>> + igt_subtest("signal-all-light")
>> + fence_signal(device, handle, ALL_ENGINES, "all", 10);
>> +
>> igt_subtest("series")
>> series(device, handle, 150);
>>
>> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
>> index f3440f31..166f158d 100644
>> --- a/tests/intel-ci/blacklist.txt
>> +++ b/tests/intel-ci/blacklist.txt
>> @@ -34,7 +34,7 @@ igt@gem_exec_flush@(?!.*basic).*
>> igt@gem_exec_gttfill@(?!.*basic).*
>> igt@gem_exec_latency(@.*)?
>> igt@gem_exec_lut_handle(@.*)?
>> -igt@gem_exec_nop@(?!.*(basic|signal-all)).*
>> +igt@gem_exec_nop@(?!.*(basic|signal-all-light)).*
>
> The real question is why is CI running it at all.
Is there any value in running anything from gem_exec_nop?
Antonio
> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-25 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 18:08 [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Add a light version of signal-all Ashutosh Dixit
2019-02-25 18:18 ` Chris Wilson
2019-02-25 18:38 ` Antonio Argenziano [this message]
2019-02-25 18:47 ` Chris Wilson
2019-02-25 18:38 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-26 2:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2037d5-bd18-9f32-9330-eec295ad6d9b@intel.com \
--to=antonio.argenziano@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.