From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7579C433F5 for ; Wed, 29 Sep 2021 03:37:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AED1613CE for ; Wed, 29 Sep 2021 03:37:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9AED1613CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KrUEYfycmdDwQEV8lO7XnLxyW+6njgfXbyZuNSU2Eb8=; b=xkEv5NNPEmMgX7Iwsla2GUoIAl ZKL5fRCZHvxhij0SrRDEd89wO24kRamQJQgO1O/BXDNPuQfHhgMNZQjOStSb+quKv2OOrDQzuUk5K S9F8TQbd8K9HmXr7nd54SLyGOQztn7mGv+bKUk7soAIVLQh0XX9551UTA62O8g76vlctx4Au8sIiT ZNMMk+YQdxStzbYlMpF02qNQRkDnZAmXGdXxxghX5K1XoA5RCDmubTpfdcIetBTxO7+jsVFV4ZMP3 CfBC0ifhTabjCIqui8mfhlYG5WMJRs9p8sxosDlYvsdPs9j2olBm5O4u9Dwg80cOfE0rEgCwaPZnW g/K/kRAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVQPS-009pZF-Fv; Wed, 29 Sep 2021 03:37:30 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVQPO-009pYZ-0e for ath11k@lists.infradead.org; Wed, 29 Sep 2021 03:37:29 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632886647; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=1Unl2lezQTicVBS8bzk/jaEWIlMos5NW7fIeXLB5YeA=; b=gN9yZGqiRGB02g6RDz22f60+JiFntn85VCGekI79drVfsEFvDWfHdw3kzYVqlju7bYILN4vq Q9JTA9ku+r1hHT/F8NC1KHH/u8lDlWdA2rPyB7wx/xpgrq5nDgRDJY6MHHI7yQdwDnFfTucl cAhCiOY4Khe1fPBOR1LI3SKAsto= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 6153df6f713d5d6f9697fcec (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Sep 2021 03:37:19 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0452FC43619; Wed, 29 Sep 2021 03:37:19 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 11944C4338F; Wed, 29 Sep 2021 03:37:17 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 29 Sep 2021 11:37:17 +0800 From: Wen Gong To: vnaralas@codeaurora.org Cc: johannes@sipsolutions.net, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, wgong=codeaurora.org@codeaurora.org Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule In-Reply-To: References: <20210928085211.26186-1-wgong@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_203727_781255_1B336928 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 2021-09-28 21:12, vnaralas@codeaurora.org wrote: > On 2021-09-28 14:22, Wen Gong wrote: >> 6 GHz regulatory domains introduces power spectral density(psd). >> The power spectral density(psd) of regulatory rule should be take >> effect to the channels. Save the values to the channel which has >> psd value and add nl80211 attributes for it. >> >> Signed-off-by: Wen Gong >> --- ... >> >> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy >> *wiphy, >> chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS; >> } >> >> + if (chan->flags & IEEE80211_CHAN_PSD) >> + chan->psd = reg_rule->psd; >> + >> chan->max_power = chan->max_reg_power; > > What about the case AP + STA concurrency? are we going to overwrite > the PSD power and channel flags? > Hi Venkateswara, This patch is not relation with AP + STA concurrency. For example, it also has other power intersection in handle_channel_adjacent_rules(). chan->max_reg_power = min_t(int, MBM_TO_DBM(power_rule1->max_eirp), MBM_TO_DBM(power_rule2->max_eirp)); For AP + STA concurrency, it should to maintain 2 group of reg rules, one is for AP, another is for STA. This patch is to handle PSD info in the same reg rules. It is to process only one reg rule in the reg rules. AP + STA concurrency is a higher level things than this patch. >> } -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1527EC433EF for ; Wed, 29 Sep 2021 03:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAFCB613D0 for ; Wed, 29 Sep 2021 03:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242296AbhI2DjN (ORCPT ); Tue, 28 Sep 2021 23:39:13 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:59864 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240701AbhI2DjL (ORCPT ); Tue, 28 Sep 2021 23:39:11 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632886649; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=1Unl2lezQTicVBS8bzk/jaEWIlMos5NW7fIeXLB5YeA=; b=SezyoVkfNE788Yc5RIwJoS0sPdiAY1A6ETvytddApUqSj9yw2yG+bnkgtMj2YBaoryPmwg9B Alf0JtILxM4xUjyh/xCK01bg8r04UR8YxnQv1gGYrKIgOg9tNQEz4EZSIzDPrEdR5/lsBxVf ShOU5uygwbqhnWe8MGrvcgmg1S8= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 6153df6f713d5d6f9697fc60 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Sep 2021 03:37:19 GMT Sender: wgong=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B1A67C43617; Wed, 29 Sep 2021 03:37:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 11944C4338F; Wed, 29 Sep 2021 03:37:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 29 Sep 2021 11:37:17 +0800 From: Wen Gong To: vnaralas@codeaurora.org Cc: johannes@sipsolutions.net, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, wgong=codeaurora.org@codeaurora.org Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule In-Reply-To: References: <20210928085211.26186-1-wgong@codeaurora.org> Message-ID: X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-09-28 21:12, vnaralas@codeaurora.org wrote: > On 2021-09-28 14:22, Wen Gong wrote: >> 6 GHz regulatory domains introduces power spectral density(psd). >> The power spectral density(psd) of regulatory rule should be take >> effect to the channels. Save the values to the channel which has >> psd value and add nl80211 attributes for it. >> >> Signed-off-by: Wen Gong >> --- ... >> >> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy >> *wiphy, >> chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS; >> } >> >> + if (chan->flags & IEEE80211_CHAN_PSD) >> + chan->psd = reg_rule->psd; >> + >> chan->max_power = chan->max_reg_power; > > What about the case AP + STA concurrency? are we going to overwrite > the PSD power and channel flags? > Hi Venkateswara, This patch is not relation with AP + STA concurrency. For example, it also has other power intersection in handle_channel_adjacent_rules(). chan->max_reg_power = min_t(int, MBM_TO_DBM(power_rule1->max_eirp), MBM_TO_DBM(power_rule2->max_eirp)); For AP + STA concurrency, it should to maintain 2 group of reg rules, one is for AP, another is for STA. This patch is to handle PSD info in the same reg rules. It is to process only one reg rule in the reg rules. AP + STA concurrency is a higher level things than this patch. >> }