All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: yicongsrfy@163.com, michal.pecio@gmail.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org
Cc: marcan@marcan.st, pabeni@redhat.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, yicong@kylinos.cn
Subject: Re: [PATCH v3 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface"
Date: Mon, 29 Sep 2025 13:15:23 +0200	[thread overview]
Message-ID: <cb280dca-b652-4fae-8a3e-d4c5a4e1d251@suse.com> (raw)
In-Reply-To: <20250929075401.3143438-1-yicongsrfy@163.com>

Hi,

On 29.09.25 09:53, yicongsrfy@163.com wrote:
> From: Yi Cong <yicong@kylinos.cn>
> 
> This reverts commit c67cc4315a8e605ec875bd3a1210a549e3562ddc.
> 
> Currently, in the Linux kernel, USB NIC with ASIX chips use the cdc_ncm
> driver. However, this driver lacks functionality and performs worse than
> the vendor's proprietary driver. In my testing, I have identified the
> following issues:

True, so we prefer the vendor specific driver if it is available
for a certain number of devices. We accept that as a given. The
exact reasons for this preference do not matter.

Now , lets look at the change log of the patch you want to revert:

     Change all the ID matches to specifically match the vendor-specific
     interface. By default the device comes up in CDC mode and is bound by
     that driver (which works fine); users may switch it to the vendor
     interface using sysfs to set bConfigurationValue, at which point the
     device actually goes through a reconnect cycle and comes back as a
     vendor specific only device, and then this driver binds and works too.

This tells us that usbcore selects the wrong configuration for these
devices. Can we remedy this via udev? Not well, there would be a race
with the wrong driver triggering an unwanted network setup.
This would be better solved in usbcore with quirks.

	Regards
		Oliver


  parent reply	other threads:[~2025-09-29 11:15 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-28  1:46 [PATCH 1/2] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" yicongsrfy
2025-09-28  1:46 ` [PATCH 2/2] net: usb: support quirks in usbnet yicongsrfy
2025-09-29  4:23   ` Jakub Kicinski
2025-09-29  5:31     ` [PATCH v2 0/3] ax88179 driver optimization yicongsrfy
2025-09-29  5:31       ` [PATCH v2 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" yicongsrfy
2025-09-29  7:02         ` Michal Pecio
2025-09-29  7:25           ` yicongsrfy
2025-09-29  5:31       ` [PATCH v2 2/3] net: usb: support quirks in usbnet yicongsrfy
2025-09-29  7:11         ` Michal Pecio
2025-09-29  7:29           ` yicongsrfy
2025-09-29  5:31       ` [PATCH v2 3/3] net: usb: ax88179_178a: add USB device driver for config selection yicongsrfy
2025-09-29  5:42         ` yicongsrfy
2025-09-29  7:53           ` [PATCH v3 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" yicongsrfy
2025-09-29  7:54             ` [PATCH v3 2/3] net: usb: support quirks in usbnet yicongsrfy
2025-09-29  7:54             ` [PATCH v3 3/3] net: usb: ax88179_178a: add USB device driver for config selection yicongsrfy
2025-09-29 11:20               ` Oliver Neukum
2025-09-29 16:11               ` Jakub Kicinski
2025-09-29 11:15             ` Oliver Neukum [this message]
2025-09-29  8:45   ` [PATCH 2/2] net: usb: support quirks in usbnet Oliver Neukum
2025-09-29  9:29     ` yicongsrfy
2025-09-29 10:21       ` Oliver Neukum
2025-09-30  8:07         ` [PATCH v4 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" yicongsrfy
2025-09-30  8:07           ` [PATCH v4 2/3] net: usb: support quirks in cdc_ncm yicongsrfy
2025-09-30  8:37             ` Greg KH
2025-09-30  8:38             ` Greg KH
2025-09-30  8:07           ` [PATCH v4 3/3] net: usb: ax88179_178a: add USB device driver for config selection yicongsrfy
2025-09-30  8:38             ` Greg KH
2025-09-30  8:57             ` Oliver Neukum
2025-10-09  7:34               ` yicongsrfy
2025-10-09  8:46                 ` Oliver Neukum
2025-10-09 11:56                 ` Andrew Lunn
2025-10-13  5:59               ` Michal Pecio
2025-10-13  8:46                 ` Oliver Neukum
2025-10-06 16:33           ` [PATCH v4 1/3] Revert "net: usb: ax88179_178a: Bind only to vendor-specific interface" Andrew Lunn
2025-09-30  8:14         ` [PATCH 2/2] net: usb: support quirks in usbnet yicongsrfy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb280dca-b652-4fae-8a3e-d4c5a4e1d251@suse.com \
    --to=oneukum@suse.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=michal.pecio@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yicong@kylinos.cn \
    --cc=yicongsrfy@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.