From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/6] drm/i915: Only track live rings for retiring Date: Mon, 23 Apr 2018 11:50:26 +0100 Message-ID: References: <20180423101400.27418-1-chris@chris-wilson.co.uk> <20180423101400.27418-3-chris@chris-wilson.co.uk> <1d2f1255-7dc6-ef51-abf1-37e1a787c514@linux.intel.com> <152447980056.5735.14671963443531499597@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 635256E19E for ; Mon, 23 Apr 2018 10:50:28 +0000 (UTC) In-Reply-To: <152447980056.5735.14671963443531499597@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIzLzA0LzIwMTggMTE6MzYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA0LTIzIDExOjI1OjU0KQo+Pgo+PiBPbiAyMy8wNC8yMDE4IDExOjEz LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBXZSBkb24ndCBuZWVkIHRvIHRyYWNrIGV2ZXJ5IHJp bmcgZm9yIGl0cyBsaWZldGltZSBhcyB0aGV5IGFyZSBtYW5hZ2VkCj4+PiBieSB0aGUgY29udGV4 dHMvZW5naW5lcy4gV2hhdCB3ZSBkbyB3YW50IHRvIHRyYWNrIGFyZSB0aGUgbGl2ZSByaW5ncyBz bwo+Pj4gdGhhdCB3ZSBjYW4gc3BvcmFkaWNhbGx5IGNsZWFuIHVwIHJlcXVlc3RzIGlmIHVzZXJz cGFjZSBmYWxscyBiZWhpbmQuIFdlCj4+PiBjYW4gc2ltcGx5IHJlc3RyaWN0IHRoZSBndC0+cmlu Z3MgbGlzdCB0byBiZWluZyBvbmx5IGd0LT5saXZlX3JpbmdzLgo+Pj4KPj4+IFN1Z2dlc3RlZC1i eTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPj4+IFNp Z25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4g Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4+PiAt LS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgICAgICAg ICB8IDIgKy0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICAg ICAgICAgICB8IDMgKystCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3Qu YyAgICAgICAgICAgICAgfCA2ICsrKysrLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV91dGlscy5oICAgICAgICAgICAgICAgIHwgNiArKysrKysKPj4+ICAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyAgICAgICAgICB8IDQgLS0tLQo+Pj4gICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICAgICAgICAgIHwgMiArLQo+Pj4gICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZW5naW5lLmMgICAgIHwgNCAtLS0t Cj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19nZW1fZGV2aWNlLmMg fCAyICstCj4+PiAgICA4IGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEzIGRlbGV0 aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4gaW5kZXggNzM5MzZiZTkw YWVkLi5hNzc4N2MyY2I1M2MgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBA QCAtMjA2MCw3ICsyMDYwLDcgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+Pj4gICAgCj4+ PiAgICAgICAgICAgICAgICBzdHJ1Y3QgaTkxNV9nZW1fdGltZWxpbmUgZ2xvYmFsX3RpbWVsaW5l Owo+Pj4gICAgICAgICAgICAgICAgc3RydWN0IGxpc3RfaGVhZCB0aW1lbGluZXM7Cj4+PiAtICAg ICAgICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgcmluZ3M7Cj4+PiArICAgICAgICAgICAgIHN0cnVj dCBsaXN0X2hlYWQgbGl2ZV9yaW5nczsKPj4+ICAgICAgICAgICAgICAgIHUzMiBhY3RpdmVfcmVx dWVzdHM7Cj4+PiAgICAKPj4+ICAgICAgICAgICAgICAgIC8qKgo+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4+PiBpbmRleCA5MDZlMjM5NWMyNDUuLjAwOTdhNzdmYWU4ZCAxMDA2NDQKPj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+IEBAIC0xNDEsNiArMTQxLDcgQEAgc3RhdGljIHUzMiBf X2k5MTVfZ2VtX3Bhcmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+PiAgICB7Cj4+ PiAgICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4+ PiAgICAgICAgR0VNX0JVR19PTihpOTE1LT5ndC5hY3RpdmVfcmVxdWVzdHMpOwo+Pj4gKyAgICAg R0VNX0JVR19PTighbGlzdF9lbXB0eSgmaTkxNS0+Z3QubGl2ZV9yaW5ncykpOwo+Pj4gICAgCj4+ PiAgICAgICAgaWYgKCFpOTE1LT5ndC5hd2FrZSkKPj4+ICAgICAgICAgICAgICAgIHJldHVybiBJ OTE1X0VQT0NIX0lOVkFMSUQ7Cj4+PiBAQCAtNTYwMCw3ICs1NjAxLDcgQEAgaW50IGk5MTVfZ2Vt X2luaXRfZWFybHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gICAgICAg ICAgICAgICAgZ290byBlcnJfZGVwZW5kZW5jaWVzOwo+Pj4gICAgCj4+PiAgICAgICAgbXV0ZXhf bG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+Pj4gLSAgICAgSU5JVF9MSVNUX0hF QUQoJmRldl9wcml2LT5ndC5yaW5ncyk7Cj4+PiArICAgICBJTklUX0xJU1RfSEVBRCgmZGV2X3By aXYtPmd0LmxpdmVfcmluZ3MpOwo+Pj4gICAgICAgIElOSVRfTElTVF9IRUFEKCZkZXZfcHJpdi0+ Z3QudGltZWxpbmVzKTsKPj4+ICAgICAgICBlcnIgPSBpOTE1X2dlbV90aW1lbGluZV9pbml0X19n bG9iYWwoZGV2X3ByaXYpOwo+Pj4gICAgICAgIG11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRybS5z dHJ1Y3RfbXV0ZXgpOwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPj4+IGluZGV4 IDBiZjk0OWVjOWYxYS4uNTM0YjhkNjg0Y2VmIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcmVxdWVzdC5jCj4+PiBAQCAtMzE2LDYgKzMxNiw3IEBAIHN0YXRpYyB2b2lkIGFkdmFuY2Vf cmluZyhzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0KQo+Pj4gICAgICAgICAgICAgICAgICog bm9vcHMgLSB0aGV5IGFyZSBzYWZlIHRvIGJlIHJlcGxheWVkIG9uIGEgcmVzZXQuCj4+PiAgICAg ICAgICAgICAgICAgKi8KPj4+ICAgICAgICAgICAgICAgIHRhaWwgPSBSRUFEX09OQ0UocmVxdWVz dC0+dGFpbCk7Cj4+PiArICAgICAgICAgICAgIGxpc3RfZGVsKCZyaW5nLT5saXZlKTsKPj4+ICAg ICAgICB9IGVsc2Ugewo+Pj4gICAgICAgICAgICAgICAgdGFpbCA9IHJlcXVlc3QtPnBvc3RmaXg7 Cj4+PiAgICAgICAgfQo+Pj4gQEAgLTEwNDYsNiArMTA0Nyw4IEBAIHZvaWQgX19pOTE1X3JlcXVl c3RfYWRkKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QsIGJvb2wgZmx1c2hfY2FjaGVzKQo+ Pj4gICAgICAgIGk5MTVfZ2VtX2FjdGl2ZV9zZXQoJnRpbWVsaW5lLT5sYXN0X3JlcXVlc3QsIHJl cXVlc3QpOwo+Pj4gICAgCj4+PiAgICAgICAgbGlzdF9hZGRfdGFpbCgmcmVxdWVzdC0+cmluZ19s aW5rLCAmcmluZy0+cmVxdWVzdF9saXN0KTsKPj4+ICsgICAgIGlmIChsaXN0X2lzX2ZpcnN0KCZy ZXF1ZXN0LT5yaW5nX2xpbmssICZyaW5nLT5yZXF1ZXN0X2xpc3QpKQo+Pj4gKyAgICAgICAgICAg ICBsaXN0X2FkZCgmcmluZy0+bGl2ZSwgJnJlcXVlc3QtPmk5MTUtPmd0LmxpdmVfcmluZ3MpOwo+ Pgo+PiBJZiB5b3UgcmUtb3JkZXIgdGhlIHR3byBsaXN0IGFkZHMgeW91IGNvdWxkIHVzZSBsaXN0 X2VtcHR5IGFuZCB3b3VsZG4ndAo+PiBoYXZlIHRvIGFkZCBsaXN0X2lzX2ZpcnN0Lgo+IAo+IGxp c3RfaXNfZmlyc3QgdGFsbGllcyBuaWNlbHkgd2l0aCB0aGUgbGlzdF9pc19sYXN0IHVzZWQgYmVm b3JlIHRoZQo+IGNvcnJlc3BvbmRpbmcgbGlzdF9kZWwuCgpZZXMgYnV0IHRvIG1lIHRoYXQncyBt aW5vciwgYmFzaWNhbGx5IGltbWF0ZXJpYWwgYXMgYXJndW1lbnQgd2hldGhlciBvciAKbm90IHRv IGFkZCBvdXIgb3duIGxpc3QgaGVscGVyLgoKPj4KPj4+ICAgICAgICByZXF1ZXN0LT5lbWl0dGVk X2ppZmZpZXMgPSBqaWZmaWVzOwo+Pj4gICAgCj4+PiAgICAgICAgLyoKPj4+IEBAIC0xMzc1LDcg KzEzNzgsOCBAQCB2b2lkIGk5MTVfcmV0aXJlX3JlcXVlc3RzKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICppOTE1KQo+Pj4gICAgICAgIGlmICghaTkxNS0+Z3QuYWN0aXZlX3JlcXVlc3RzKQo+Pj4g ICAgICAgICAgICAgICAgcmV0dXJuOwo+Pj4gICAgCj4+PiAtICAgICBsaXN0X2Zvcl9lYWNoX2Vu dHJ5X3NhZmUocmluZywgbmV4dCwgJmk5MTUtPmd0LnJpbmdzLCBsaW5rKQo+Pj4gKyAgICAgR0VN X0JVR19PTihsaXN0X2VtcHR5KCZpOTE1LT5ndC5saXZlX3JpbmdzKSk7Cj4+Cj4+IE1heWJlIGJs YW5rIGxpbmUgaGVyZSBzaW5jZSB0aGUgYXNzZXJ0IGlzIG5vdCBsb2dpY2FsbHkgYXNzb2NpYXRl ZCB3aXRoCj4+IHRoZSBsaXN0IGJ1dCB3aXRoIHRoZSAhaTkxNS5hY3RpdmVfcmVxdWVzdHM/Cj4g Cj4gSSB3YXMgdGhpbmtpbmcgbGlzdCB3aGVuIEkgd3JvdGUgaXQuIEl0J3Mgc21hbGwgZW5vdWdo IHdlIGNhbiBhcmd1ZSBib3RoCj4gYW5kIGJvdGggYmUgcmlnaHQuCgpIbSBvYnZpb3N1bHkgaXQg aXMgbm90IGFuIGVycm9yIHRvIGNhbGwgaTkxNV9yZXRpcmVfcmVxdWVzdHMgd2l0aCAKbm90aGlu ZyBhY3RpdmUgKGVhcmx5IHJldHVybikuIFNvIEkgZXZlbiBicmllZmx5IHdhbnRlZCB0byBzdWdn ZXN0IHRvIAptYWtlIGl0IDEwMCUgZXhwbGljaXQgYW5kIGhhdmUgdGhlIGFzc2VydCBhdCB0aGUg dG9wIG9mIHRoZSBmdW5jdGlvbiBhczoKCkdFTV9CVUdfT04oISFpOTE1LT5ndC5hY3RpdmVfcmVx dWVzdHMgXiAhIWxpc3RfZW1wdHkoLi4pKTsKClVubGVzcyBJIG1lc3NlZCBpdCB1cCwgdGhlIGlk ZWEgaXMgdG8gY2hlY2sgdGhvc2UgdHdvIGFyZSBhbHdheXMgaW4gdGhlIApzYW1lIHN0YXRlLgoK PiAKPj4KPj4+ICsgICAgIGxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShyaW5nLCBuZXh0LCAmaTkx NS0+Z3QubGl2ZV9yaW5ncywgbGl2ZSkKPj4+ICAgICAgICAgICAgICAgIHJpbmdfcmV0aXJlX3Jl cXVlc3RzKHJpbmcpOwo+Pj4gICAgfQo+Pj4gICAgCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV91dGlscy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGls cy5oCj4+PiBpbmRleCAwNjk1NzE3NTIyZWEuLjAwMTY1YWQ1NWZiMyAxMDA2NDQKPj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdXRpbHMuaAo+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV91dGlscy5oCj4+PiBAQCAtMTIwLDYgKzEyMCwxMiBAQCBzdGF0aWMgaW5s aW5lIHU2NCBwdHJfdG9fdTY0KGNvbnN0IHZvaWQgKnB0cikKPj4+ICAgIAo+Pj4gICAgI2luY2x1 ZGUgPGxpbnV4L2xpc3QuaD4KPj4+ICAgIAo+Pj4gK3N0YXRpYyBpbmxpbmUgaW50IGxpc3RfaXNf Zmlyc3QoY29uc3Qgc3RydWN0IGxpc3RfaGVhZCAqbGlzdCwKPj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQpCj4+Cj4+IFJldHVybiBi b29sIGlmIHlvdSBkZWNpZGUgeW91IHByZWZlciB0byBrZWVwIGxpc3RfaXNfZmlyc3Q/Cj4gCj4g Q29weSduJ3Bhc3RlIGZyb20gbGlzdF9pc19sYXN0KCkuCj4gCj4+Cj4+PiArewo+Pj4gKyAgICAg cmV0dXJuIGhlYWQtPm5leHQgPT0gbGlzdDsKPj4+ICt9Cj4+PiArCj4+PiAgICBzdGF0aWMgaW5s aW5lIHZvaWQgX19saXN0X2RlbF9tYW55KHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQsCj4+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGxpc3RfaGVhZCAqZmlyc3QpCj4+ PiAgICB7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+PiBpbmRl eCA3OTJhMmNhOTU4NzIuLjM0NTNlNzQyNmY2YiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+PiBAQCAtMTE1MCw4ICsxMTUwLDYgQEAgaW50ZWxfZW5n aW5lX2NyZWF0ZV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgaW50IHNpemUp Cj4+PiAgICAgICAgfQo+Pj4gICAgICAgIHJpbmctPnZtYSA9IHZtYTsKPj4+ICAgIAo+Pj4gLSAg ICAgbGlzdF9hZGQoJnJpbmctPmxpbmssICZlbmdpbmUtPmk5MTUtPmd0LnJpbmdzKTsKPj4+IC0K Pj4+ICAgICAgICByZXR1cm4gcmluZzsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gQEAgLTExNjMsOCAr MTE2MSw2IEBAIGludGVsX3JpbmdfZnJlZShzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZykKPj4+ICAg ICAgICBpOTE1X3ZtYV9jbG9zZShyaW5nLT52bWEpOwo+Pj4gICAgICAgIF9faTkxNV9nZW1fb2Jq ZWN0X3JlbGVhc2VfdW5sZXNzX2FjdGl2ZShvYmopOwo+Pj4gICAgCj4+PiAtICAgICBsaXN0X2Rl bCgmcmluZy0+bGluayk7Cj4+PiAtCj4+PiAgICAgICAga2ZyZWUocmluZyk7Cj4+PiAgICB9Cj4+ PiAgICAKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4+IGluZGV4 IGQ4MTZmOGRlYTI0NS4uZmQ1YTYzNjNhYjFkIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmgKPj4+IEBAIC0xMjksNyArMTI5LDcgQEAgc3RydWN0IGludGVs X3Jpbmcgewo+Pj4gICAgICAgIHZvaWQgKnZhZGRyOwo+Pj4gICAgCj4+PiAgICAgICAgc3RydWN0 IGxpc3RfaGVhZCByZXF1ZXN0X2xpc3Q7Cj4+PiAtICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpbms7 Cj4+PiArICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpdmU7Cj4+Cj4+IGxpdmVfbGluaz8KPiAKPiBs aXZlIG9yIGFjdGl2ZS4KPiAKPiBhY3RpdmVfcmluZ3MgdGllcyBpbiB3aXRoIGFjdGl2ZV9yZXF1 ZXN0cywgc28gYWN0aXZlX2xpbmsgaGVyZS4KCkZpbmUgYnkgbWUuCgpSZWdhcmRzLAoKVHZydGtv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=