Re: [RFC bpf-next 1/5] selftests/bpf: support custom per-test flags and multiple expected messages

[Eduard Zingerman <eddyz87@gmail.com>]

On Wed, 2023-03-01 at 09:12 -0800, Andrii Nakryiko wrote:
[...]
> > Rebase didn't change anything in the patch, I added __flags macro,
> > some some comments, and started the CI job: [1].
> > 
> > Feels weird to post it, tbh, because it's 100% your code w/o added
> > value from my side.
> 
> you took the effort to prepare it for submission, testing, and
> integrating into your work, so feels well deserved
> 
> 
> > 
> > Thanks,
> > Eduard
> > 
> > [1] https://github.com/kernel-patches/bpf/pull/4688
> 
> apart from test flakiness, looks good, please send a patch "officially"

Done.
Local test run does not show any issues.

> 
> > > 
> > > 
> > > 
> > > >  tools/testing/selftests/bpf/test_loader.c | 69 ++++++++++++++++++++---
> > > >  tools/testing/selftests/bpf/test_progs.h  |  1 +
> > > >  2 files changed, 61 insertions(+), 9 deletions(-)
> > > > 
> > > > diff --git a/tools/testing/selftests/bpf/test_loader.c b/tools/testing/selftests/bpf/test_loader.c
> > > > index 679efb3aa785..bf41390157bf 100644
> > > > --- a/tools/testing/selftests/bpf/test_loader.c
> > > > +++ b/tools/testing/selftests/bpf/test_loader.c
> > > > @@ -13,12 +13,15 @@
> > > >  #define TEST_TAG_EXPECT_SUCCESS "comment:test_expect_success"
> > > >  #define TEST_TAG_EXPECT_MSG_PFX "comment:test_expect_msg="
> > > >  #define TEST_TAG_LOG_LEVEL_PFX "comment:test_log_level="
> > > > +#define TEST_TAG_PROG_FLAGS_PFX "comment:test_prog_flags="
> > > > 
> > > 
> > > [...]
> >