All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	artem.bityutskiy@linux.intel.com, andi.kleen@intel.com
Subject: Re: [PATCH] perf vendor events intel: Add Emerald Rapids
Date: Wed, 18 Jan 2023 15:14:25 -0500	[thread overview]
Message-ID: <cb4b6b3c-5151-ed9d-ba17-e8a5f919f8f8@linux.intel.com> (raw)
In-Reply-To: <CAP-5=fWMPYmofTL262HQB1jOiqRD5dKtAhaWrBbT-vq-NYsXcg@mail.gmail.com>



On 2023-01-18 1:02 p.m., Ian Rogers wrote:
> On Wed, Jan 18, 2023 at 9:57 AM <kan.liang@linux.intel.com> wrote:
>>
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> The event list of the Emerald Rapids is the same as the Sapphire
>> Rapids. Add the CPU model ID of Emerald Rapids into the mapfile.csv and
>> point it to the event list of Sapphire Rapids.
>>
>> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>
>> I note it currently isn't on the perfmon github:
> https://github.com/intel/perfmon/blob/main/mapfile.csv

Right, but it will be fixed soon.

Thanks,
Kan
> This will create a diff from the version of mapfile.csv generated by:
> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> Presumably there will be an update to solve that.>
> Thanks,
> Ian
> 
>> ---
>>  tools/perf/pmu-events/arch/x86/mapfile.csv | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
>> index 711a4ef05fdf..5facdac6fe8e 100644
>> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
>> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
>> @@ -21,7 +21,7 @@ GenuineIntel-6-A[AC],v1.00,meteorlake,core
>>  GenuineIntel-6-1[AEF],v3,nehalemep,core
>>  GenuineIntel-6-2E,v3,nehalemex,core
>>  GenuineIntel-6-2A,v17,sandybridge,core
>> -GenuineIntel-6-8F,v1.09,sapphirerapids,core
>> +GenuineIntel-6-(8F|CF),v1.09,sapphirerapids,core
>>  GenuineIntel-6-(37|4A|4C|4D|5A),v14,silvermont,core
>>  GenuineIntel-6-(4E|5E|8E|9E|A5|A6),v53,skylake,core
>>  GenuineIntel-6-55-[01234],v1.28,skylakex,core
>> --
>> 2.35.1
>>

  reply	other threads:[~2023-01-18 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 17:56 [PATCH] perf vendor events intel: Add Emerald Rapids kan.liang
2023-01-18 18:02 ` Ian Rogers
2023-01-18 20:14   ` Liang, Kan [this message]
2023-01-19 12:56   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb4b6b3c-5151-ed9d-ba17-e8a5f919f8f8@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=andi.kleen@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.