All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: devicetree@vger.kernel.org,
	srv_heupstream <srv_heupstream@mediatek.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>, CK HU <ck.hu@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v17 0/6] support gce on mt8183 platform
Date: Thu, 12 Dec 2019 08:49:00 +0100	[thread overview]
Message-ID: <cb5cd58e-dc62-ae30-9ddd-7c2b95fde3e3@gmail.com> (raw)
In-Reply-To: <CANMq1KCTJQL+GFqo8HYM8cEpzXJmebJ=9ju4CzHLwyuQfbZEAA@mail.gmail.com>



On 11/12/2019 23:09, Nicolas Boichat wrote:
> Hi Matthias,
> 
> Quick question, any reason you picked only patches 2+3+6 from this
> series, and not the 3 others?
> 

The quick answer, time :)
The longer one:
1/6 went already in through fixes for v5.4
4/6 it touches mailbox code, so we will need a acked-by from Jassi
5/6 time, I want to have a better look onto this to see if that makes sense (I
slightly remember some old comment I had on this)

Regards,
Matthias

> Thanks.
> 
> On Wed, Nov 20, 2019 at 5:54 PM Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
>>
>> Changes since v16:
>>  - naming the poll mask enable bit
>>  - add a patch to fiup the input order of write api
>>
>> Changes since v15:
>>  - rebase onto 5.4-rc1
>>  - rollback the v14 change
>>  - add a patch to fixup the combination of return value
>>
>> Changes since v14:
>>  - change input argument as pointer in append_commend()
>>
>> Changes since v13:
>>  - separate poll function as poll w/ & w/o mask function
>>  - directly pass inst into append_command function instead
>>    of returns a pointer
>>  - fixup coding style
>>  - rebase onto 5.3-rc1
>>
>> [... snip ...]
>>
>> Bibby Hsieh (6):
>>   soc: mediatek: cmdq: fixup wrong input order of write api
>>   soc: mediatek: cmdq: remove OR opertaion from err return
>>   soc: mediatek: cmdq: define the instruction struct
>>   soc: mediatek: cmdq: add polling function
>>   soc: mediatek: cmdq: add cmdq_dev_get_client_reg function
>>   arm64: dts: add gce node for mt8183
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi |  10 ++
>>  drivers/soc/mediatek/mtk-cmdq-helper.c   | 147 +++++++++++++++++++----
>>  include/linux/mailbox/mtk-cmdq-mailbox.h |  11 ++
>>  include/linux/soc/mediatek/mtk-cmdq.h    |  53 ++++++++
>>  4 files changed, 195 insertions(+), 26 deletions(-)
>>
>> --
>> 2.18.0

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: devicetree@vger.kernel.org,
	srv_heupstream <srv_heupstream@mediatek.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>, CK HU <ck.hu@mediatek.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v17 0/6] support gce on mt8183 platform
Date: Thu, 12 Dec 2019 08:49:00 +0100	[thread overview]
Message-ID: <cb5cd58e-dc62-ae30-9ddd-7c2b95fde3e3@gmail.com> (raw)
In-Reply-To: <CANMq1KCTJQL+GFqo8HYM8cEpzXJmebJ=9ju4CzHLwyuQfbZEAA@mail.gmail.com>



On 11/12/2019 23:09, Nicolas Boichat wrote:
> Hi Matthias,
> 
> Quick question, any reason you picked only patches 2+3+6 from this
> series, and not the 3 others?
> 

The quick answer, time :)
The longer one:
1/6 went already in through fixes for v5.4
4/6 it touches mailbox code, so we will need a acked-by from Jassi
5/6 time, I want to have a better look onto this to see if that makes sense (I
slightly remember some old comment I had on this)

Regards,
Matthias

> Thanks.
> 
> On Wed, Nov 20, 2019 at 5:54 PM Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
>>
>> Changes since v16:
>>  - naming the poll mask enable bit
>>  - add a patch to fiup the input order of write api
>>
>> Changes since v15:
>>  - rebase onto 5.4-rc1
>>  - rollback the v14 change
>>  - add a patch to fixup the combination of return value
>>
>> Changes since v14:
>>  - change input argument as pointer in append_commend()
>>
>> Changes since v13:
>>  - separate poll function as poll w/ & w/o mask function
>>  - directly pass inst into append_command function instead
>>    of returns a pointer
>>  - fixup coding style
>>  - rebase onto 5.3-rc1
>>
>> [... snip ...]
>>
>> Bibby Hsieh (6):
>>   soc: mediatek: cmdq: fixup wrong input order of write api
>>   soc: mediatek: cmdq: remove OR opertaion from err return
>>   soc: mediatek: cmdq: define the instruction struct
>>   soc: mediatek: cmdq: add polling function
>>   soc: mediatek: cmdq: add cmdq_dev_get_client_reg function
>>   arm64: dts: add gce node for mt8183
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi |  10 ++
>>  drivers/soc/mediatek/mtk-cmdq-helper.c   | 147 +++++++++++++++++++----
>>  include/linux/mailbox/mtk-cmdq-mailbox.h |  11 ++
>>  include/linux/soc/mediatek/mtk-cmdq.h    |  53 ++++++++
>>  4 files changed, 195 insertions(+), 26 deletions(-)
>>
>> --
>> 2.18.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
	Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>,
	devicetree@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>
Subject: Re: [PATCH v17 0/6] support gce on mt8183 platform
Date: Thu, 12 Dec 2019 08:49:00 +0100	[thread overview]
Message-ID: <cb5cd58e-dc62-ae30-9ddd-7c2b95fde3e3@gmail.com> (raw)
In-Reply-To: <CANMq1KCTJQL+GFqo8HYM8cEpzXJmebJ=9ju4CzHLwyuQfbZEAA@mail.gmail.com>



On 11/12/2019 23:09, Nicolas Boichat wrote:
> Hi Matthias,
> 
> Quick question, any reason you picked only patches 2+3+6 from this
> series, and not the 3 others?
> 

The quick answer, time :)
The longer one:
1/6 went already in through fixes for v5.4
4/6 it touches mailbox code, so we will need a acked-by from Jassi
5/6 time, I want to have a better look onto this to see if that makes sense (I
slightly remember some old comment I had on this)

Regards,
Matthias

> Thanks.
> 
> On Wed, Nov 20, 2019 at 5:54 PM Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
>>
>> Changes since v16:
>>  - naming the poll mask enable bit
>>  - add a patch to fiup the input order of write api
>>
>> Changes since v15:
>>  - rebase onto 5.4-rc1
>>  - rollback the v14 change
>>  - add a patch to fixup the combination of return value
>>
>> Changes since v14:
>>  - change input argument as pointer in append_commend()
>>
>> Changes since v13:
>>  - separate poll function as poll w/ & w/o mask function
>>  - directly pass inst into append_command function instead
>>    of returns a pointer
>>  - fixup coding style
>>  - rebase onto 5.3-rc1
>>
>> [... snip ...]
>>
>> Bibby Hsieh (6):
>>   soc: mediatek: cmdq: fixup wrong input order of write api
>>   soc: mediatek: cmdq: remove OR opertaion from err return
>>   soc: mediatek: cmdq: define the instruction struct
>>   soc: mediatek: cmdq: add polling function
>>   soc: mediatek: cmdq: add cmdq_dev_get_client_reg function
>>   arm64: dts: add gce node for mt8183
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi |  10 ++
>>  drivers/soc/mediatek/mtk-cmdq-helper.c   | 147 +++++++++++++++++++----
>>  include/linux/mailbox/mtk-cmdq-mailbox.h |  11 ++
>>  include/linux/soc/mediatek/mtk-cmdq.h    |  53 ++++++++
>>  4 files changed, 195 insertions(+), 26 deletions(-)
>>
>> --
>> 2.18.0

  reply	other threads:[~2019-12-12  7:49 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21  1:54 [PATCH v17 0/6] support gce on mt8183 platform Bibby Hsieh
2019-11-21  1:54 ` Bibby Hsieh
2019-11-21  1:54 ` Bibby Hsieh
2019-11-21  1:54 ` [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-22  8:05   ` CK Hu
2019-11-22  8:05     ` CK Hu
2019-11-22  8:05     ` CK Hu
2019-11-21  1:54 ` [PATCH v17 2/6] soc: mediatek: cmdq: remove OR opertaion from err return Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-12-11 18:26   ` Matthias Brugger
2019-12-11 18:26     ` Matthias Brugger
2019-12-11 18:26     ` Matthias Brugger
2019-11-21  1:54 ` [PATCH v17 3/6] soc: mediatek: cmdq: define the instruction struct Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-22  8:30   ` CK Hu
2019-11-22  8:30     ` CK Hu
2019-11-22  8:30     ` CK Hu
2019-12-11 18:39     ` Matthias Brugger
2019-12-11 18:39       ` Matthias Brugger
2019-12-11 18:39       ` Matthias Brugger
2019-11-21  1:54 ` [PATCH v17 4/6] soc: mediatek: cmdq: add polling function Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-22  8:36   ` CK Hu
2019-11-22  8:36     ` CK Hu
2019-11-22  8:36     ` CK Hu
2019-12-14 21:45   ` Matthias Brugger
2019-12-14 21:45     ` Matthias Brugger
2019-12-14 21:45     ` Matthias Brugger
2019-11-21  1:54 ` [PATCH v17 5/6] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-12-14 21:57   ` Matthias Brugger
2019-12-14 21:57     ` Matthias Brugger
2019-12-14 21:57     ` Matthias Brugger
2019-11-21  1:54 ` [PATCH v17 6/6] arm64: dts: add gce node for mt8183 Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-11-21  1:54   ` Bibby Hsieh
2019-12-11 18:56   ` Matthias Brugger
2019-12-11 18:56     ` Matthias Brugger
2019-12-11 18:56     ` Matthias Brugger
2019-12-11 22:09 ` [PATCH v17 0/6] support gce on mt8183 platform Nicolas Boichat
2019-12-11 22:09   ` Nicolas Boichat
2019-12-11 22:09   ` Nicolas Boichat
2019-12-12  7:49   ` Matthias Brugger [this message]
2019-12-12  7:49     ` Matthias Brugger
2019-12-12  7:49     ` Matthias Brugger
2019-12-12  9:47     ` Bibby Hsieh
2019-12-12  9:47       ` Bibby Hsieh
2019-12-12  9:47       ` Bibby Hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb5cd58e-dc62-ae30-9ddd-7c2b95fde3e3@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=bibby.hsieh@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=dennis-yc.hsieh@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.