From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748F9C47082 for ; Mon, 7 Jun 2021 14:44:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D33D610C7 for ; Mon, 7 Jun 2021 14:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D33D610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C85CA166F; Mon, 7 Jun 2021 16:43:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C85CA166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623077056; bh=BHn940bkEHf3Gh/VnyDkP7MEHwlUdkdAZioP6lNTSIg=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=E5TWAgxycGaB+w/CIPmm2du7kRIX/ZJ15yIkFfMM3OusO7donnLIpVQqifd5GPtW+ G5WFj2vuGeKwvgG4JsEvRdgK1U5AyHIg57vwmlw/5mYR9RP3IJYTHUSLstOyK3Hzay GqFzCm2/wUgb4gxasKbLQ7MbqLgKMYtk7A5Bz8iY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6980DF800AF; Mon, 7 Jun 2021 16:43:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id F22BEF80212; Mon, 7 Jun 2021 16:43:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03993F800AF for ; Mon, 7 Jun 2021 16:43:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03993F800AF IronPort-SDR: WWFCLKVPfRXynJoYzFsKnv4GpY5FRwJZD96UPeO9gT7GOg3GsB9TWDBWeE0L81AwpR23t6qS5K Ww/oCAZfyMqQ== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="185003727" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="185003727" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 07:43:06 -0700 IronPort-SDR: CeHH2bAx8sbXJSgflxrJfs1CIzAPWJ5w8atWCRvUHRcBtt4VcLlUvP21ft1ZLtBUi0afvQkJbG ScBsXQMEP20g== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="447503469" Received: from dsanc15x-mobl3.amr.corp.intel.com (HELO [10.251.138.253]) ([10.251.138.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 07:43:04 -0700 Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <20210606004102.26190-1-brent.lu@intel.com> <20210606004102.26190-4-brent.lu@intel.com> <505c7e46-316c-9fa1-feaa-115f4561ed19@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 7 Jun 2021 09:43:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: "Nujella, Sathyanarayana" , Guennadi Liakhovetski , "Rojewski, Cezary" , "R, Dharageswari" , Kuninori Morimoto , Kai Vehmanen , Jie Yang , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Tzung-Bi Shih , Mark Brown , Ranjani Sridharan , "M, Naveen" , "Wang, Rander" , Bard Liao , Fred Oh , "Gopal, Vamshi Krishna" , "Zhi, Yong" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/7/21 9:29 AM, Lu, Brent wrote: >> On 6/5/21 7:41 PM, Brent Lu wrote: >>> This patch adds driver data for jsl_cs4242_mx98360a which supports two >>> max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on >>> SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682 >>> machine driver to reuse the topology. >> >> This also looks like we have two topologies configuring the same DAIs >> differently on different platforms. >> >> Why can't we pick one configuration that would work in all cases? >> > > The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg. > This patch does not care about the dai sequence. Maybe I should reword the > commit log. I was referring to the bclk frequency, one case uses 2.4 and the other 3.072MHz. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A30CC47082 for ; Mon, 7 Jun 2021 14:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EB45610C7 for ; Mon, 7 Jun 2021 14:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbhFGOo7 (ORCPT ); Mon, 7 Jun 2021 10:44:59 -0400 Received: from mga09.intel.com ([134.134.136.24]:20750 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230266AbhFGOo5 (ORCPT ); Mon, 7 Jun 2021 10:44:57 -0400 IronPort-SDR: FwZyGfmcnoe3T8G35QN+UKwETiOeVv6tF4r4l5MCz+uDPon/OsyuNvxcUTugp4tXPuGC8ny5CW tv3vn5s/DmLg== X-IronPort-AV: E=McAfee;i="6200,9189,10008"; a="204602881" X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="204602881" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 07:43:06 -0700 IronPort-SDR: CeHH2bAx8sbXJSgflxrJfs1CIzAPWJ5w8atWCRvUHRcBtt4VcLlUvP21ft1ZLtBUi0afvQkJbG ScBsXQMEP20g== X-IronPort-AV: E=Sophos;i="5.83,255,1616482800"; d="scan'208";a="447503469" Received: from dsanc15x-mobl3.amr.corp.intel.com (HELO [10.251.138.253]) ([10.251.138.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2021 07:43:04 -0700 Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a To: "Lu, Brent" , "alsa-devel@alsa-project.org" Cc: Guennadi Liakhovetski , "Rojewski, Cezary" , "R, Dharageswari" , Kuninori Morimoto , Kai Vehmanen , Tzung-Bi Shih , "linux-kernel@vger.kernel.org" , Jie Yang , Takashi Iwai , Liam Girdwood , "Zhi, Yong" , Mark Brown , Ranjani Sridharan , "M, Naveen" , "Wang, Rander" , Bard Liao , Fred Oh , "Gopal, Vamshi Krishna" , "Nujella, Sathyanarayana" References: <20210606004102.26190-1-brent.lu@intel.com> <20210606004102.26190-4-brent.lu@intel.com> <505c7e46-316c-9fa1-feaa-115f4561ed19@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 7 Jun 2021 09:43:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/7/21 9:29 AM, Lu, Brent wrote: >> On 6/5/21 7:41 PM, Brent Lu wrote: >>> This patch adds driver data for jsl_cs4242_mx98360a which supports two >>> max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on >>> SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682 >>> machine driver to reuse the topology. >> >> This also looks like we have two topologies configuring the same DAIs >> differently on different platforms. >> >> Why can't we pick one configuration that would work in all cases? >> > > The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg. > This patch does not care about the dai sequence. Maybe I should reword the > commit log. I was referring to the bclk frequency, one case uses 2.4 and the other 3.072MHz.