All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kelly <martin.kelly@crowdstrike.com>
To: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>
Cc: "daniel@iogearbox.net" <daniel@iogearbox.net>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"ast@kernel.org" <ast@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kernel-team@fb.com" <kernel-team@fb.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"andrii@kernel.org" <andrii@kernel.org>
Subject: RE: Re: Re: Clarification on bpftool dual licensing
Date: Thu, 18 Nov 2021 16:37:55 +0000	[thread overview]
Message-ID: <cb8074f8c8554ca480d6bb57f79535fc@crowdstrike.com> (raw)

> On Wed, Nov 17, 2021 at 4:32 PM Martin Kelly
> <martin.kelly@crowdstrike.com> wrote:
> >
> > >
> > > On Tue, Nov 16, 2021 at 2:16 AM Daniel Borkmann
> <daniel@iogearbox.net>
> > > wrote:
> > > >
> > > > On 11/15/21 7:20 PM, Martin Kelly wrote:
> > > > > Hi,
> > > > >
> > > > > I have a question regarding the dual licensing provision of bpftool. I
> > > > > understand that bpftool can be distributed as either GPL 2.0 or BSD 2-
> > > clause.
> > > > > That said, bpftool can also auto-generate BPF code that gets specified
> inline
> > > > > in the skeleton header file, and it's possible that the BPF code generated
> is
> > > > > GPL. What I'm wondering is what happens if bpftool generates GPL-
> licensed
> > > BPF
> > > > > code inside the skeleton header, so that you get a header like this:
> > > > >
> > > > > something.skel.h:
> > > > > /* this file is BSD 2-clause, by nature of dual licensing */
> > > >
> > > > Fwiw, the generated header contains an SPDX identifier:
> > > >
> > > >   /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > > >   /* THIS FILE IS AUTOGENERATED! */
> > > >
> > > > > /* THIS FILE IS AUTOGENERATED! */
> > > > >
> > > > > /* standard skeleton definitions */
> > > > >
> > > > > ...
> > > > >
> > > > > s->data_sz = XXX;
> > > > > s->data = (void *)"\
> > > > > <eBPF bytecode, produced by GPL 2.0 sources, specified in binary>
> > > > > ";
> > > > >
> > > > > My guess is that, based on the choice to dual-license bpftool, the header
> is
> > > > > meant to still be BSD 2-clause, and the s->data inline code's GPL license
> is
> > > > > not meant to change the licensing of the header itself, but I wanted to
> > >
> > > Yes, definitely that is the intent (but not a lawyer either).
> >
> >  Thanks everyone, that's what I assumed as well. Any objection to a patch
> clarifying this more explicitly?
> >
> > One other, related question: vmlinux.h (generated by "bpftool btf dump file
> /sys/kernel/btf/vmlinux format c"), does not currently contain a license
> declaration. I assume this would have to be a GPL header, since vmlinux.h
> references many GPL'd Linux kernel structs and similar, though again I'm not a
> lawyer and therefore am not certain. Would you all agree with this? If so, any
> objection to a patch adding an SPDX line to the generated vmlinux.h?
>
> Is vmlinux DWARF data GPL'ed? I certainly hope not. So vmlinux.h
> shouldn't be licensed under GPL.

I have no idea; I had assumed that a struct definition coming from a GPL-licensed header would have to be GPL, but again, not a lawyer, and I could totally be wrong. If not GPL though, what would the license be? Is it just "output of a program" and therefore license-less, even though the output happens to be code?

             reply	other threads:[~2021-11-18 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 16:37 Martin Kelly [this message]
2021-11-19 12:54 ` Re: Re: Clarification on bpftool dual licensing Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb8074f8c8554ca480d6bb57f79535fc@crowdstrike.com \
    --to=martin.kelly@crowdstrike.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.