From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: WoL broken in r8169.c since kernel 4.19 Date: Sat, 12 Jan 2019 21:28:48 +0100 Message-ID: References: <20190112200831.GB20268@torres.zugschlus.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: "netdev@vger.kernel.org" To: Marc Haber , Alex Xu , Anthony Wong , Azat Khuzhin , "David S. Miller" , Hans de Goede , Jian-Hong Pan , Kai-Heng Feng , "Maciej S. Szmigiero" Return-path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:40593 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfALU24 (ORCPT ); Sat, 12 Jan 2019 15:28:56 -0500 Received: by mail-wm1-f67.google.com with SMTP id f188so5378333wmf.5 for ; Sat, 12 Jan 2019 12:28:55 -0800 (PST) In-Reply-To: <20190112200831.GB20268@torres.zugschlus.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12.01.2019 21:08, Marc Haber wrote: > Hi, > > I am writing to all people who have commits in r8169.c between the v4.18 > and v4.19 tags in the Linux kernel. Please ignore as appropriate. If > you'd prefer that to be on a mailing list, please indicate on which list > you want to have that, and I'll resend. > It should be cc'ed to the netdev mailing list, as listed in MAINTAINERS. > My desktop copmuter has the following network interface: > > 06:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06) > Subsystem: ASUSTeK Computer Inc. P8P67 and other motherboards > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Latency: 0, Cache Line Size: 64 bytes > Interrupt: pin A routed to IRQ 17 > NUMA node: 0 > Region 0: I/O ports at e800 [size=256] > Region 2: Memory at fdfff000 (64-bit, prefetchable) [size=4K] > Region 4: Memory at fdff8000 (64-bit, prefetchable) [size=16K] > Capabilities: > Kernel driver in use: r8169 > Kernel modules: r8169 > Unfortunately there's different chip versions with the same description. Please provide the result of "dmesg | grep XID". > I regularly buíld a VPN tunnel to my local network from 'on the road' > and use WoL to wake up the desktop box when I need it. > > Since kernel 4.19, that does not work any more, the desktop remains > suspended when I send it a magic packet. This still applies to 4.20.1, > and it still works with any 4.18 kernel. > WoL works perfectly fine here with r8169 from runtime-suspend and from S3. How do you enable WoL? And which WoL method do you use (magic packet or ..) ? Please provide a register dump (ethtool -d ). > I transplanted the 4.18 r8169.c into 4.20.1, and then WoL worked again. > Thus, the issue must have been introduced between 4.18 and 4.19. > > Does anybody of you have an idea how to find the issue in the 4.20 code? > > I have seen 648458fe97b5c0630435fa2b2cd65ba57ceb18e0 in 4.19.14 and > tried applying it to 4.20.1 (was necessary to do it manually because the > patch wouldn't apply), but that one didn't help. > > 4.19.14, which has a WoL-related patch applied, doesn't wake on LAN as > well. > > I tried bisecting for r8169.c between v4.18 and v4.19, but right the > first step didn't even boot far enough for the disk password prompt, so > I am at a loss here. > > Any ideas? > > Greetings > Marc > > Heiner