Re: [PATCH v5 08/12] gpio: aggregator: export symbols of the GPIO forwarder library

[Thomas Richard <thomas.richard@bootlin.com>]

On 5/7/25 08:29, Andy Shevchenko wrote:
>> +/**
>> + * gpio_fwd_gpio_add - Add a GPIO in the forwarder
> 
> forwarder

Sorry I do not see the typo :)

> 
>> + * @fwd: GPIO forwarder
>> + * @desc: GPIO decriptor to register
> 
> descriptor
> 
>> + * @offset: offset for the GPIO in the forwarder
>> + *
>> + * Returns: 0 on success, or negative errno on failure.
>> + */
> 
> Please, spellcheck all of the comments.

Ditto

> 
> ...
> 
>> +#ifndef __LINUX_GPIO_FORWARDER_H
>> +#define __LINUX_GPIO_FORWARDER_H
> 
>> +#include <linux/gpio/consumer.h>
>> +#include <linux/gpio/driver.h>
> 
> These are not used (at least as of this patch).

Indeed they are only needed in the pinctrl driver.

> 
> + struct gpio_chip;

And also struct gpio_desc;

Regards,

Thomas