From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com, fio@vger.kernel.org
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 2/8] Makefile: use fmt(1) rather than tr(1) on NetBSD/etc
Date: Fri, 23 Jun 2017 16:18:59 -0600 [thread overview]
Message-ID: <cba12c06-e24f-2af9-f97e-37bd2ebd583d@kernel.dk> (raw)
In-Reply-To: <20170623220801.38178-3-tkusumi@tuxera.com>
On 06/23/2017 04:07 PM, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> e291cff1 (Use fmt -w WIDTH option instead of -WIDTH) changed the
> command option to a common one to suppress an error, but it only
> fixed the unknown option error without being functional on NetBSD.
>
> This change is taken from NetBSD's pkgsrc. It may work against
> other platforms that don't work with fmt(1), but only enabled for
> NetBSD at the moment. FreeBSD/DragonFlyBSD/OpenBSD work with fmt(1).
>
> (This actually works on Linux too, but the existing one should be
> kept for Linux (and other platforms) provided it has been used on
> various distros for years)
>
> https://github.com/NetBSD/pkgsrc/blob/trunk/benchmarks/fio/patches/patch-Makefile
>
>> Convert the fmt(1) command to a tr(1) one (the fmt(1) old syntax
>> command is not supported on all Unix systems).
Not crazy about the target dependency on netbsd for using tr. But I
guess it's better we have it working.
--
Jens Axboe
next prev parent reply other threads:[~2017-06-23 22:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 22:07 [PATCH 0/8] option/Makefile fix and void* fixups kusumi.tomohiro
2017-06-23 22:07 ` [PATCH 1/8] ignore directory= if the given path is absolute kusumi.tomohiro
2017-06-23 22:16 ` Jens Axboe
2017-06-23 22:24 ` Tomohiro Kusumi
2017-06-23 22:07 ` [PATCH 2/8] Makefile: use fmt(1) rather than tr(1) on NetBSD/etc kusumi.tomohiro
2017-06-23 22:18 ` Jens Axboe [this message]
2017-06-23 22:07 ` [PATCH 3/8] server: don't use void* for pointer arithmetic (gcc) kusumi.tomohiro
2017-06-23 22:07 ` [PATCH 4/8] io_u: " kusumi.tomohiro
2017-06-23 22:07 ` [PATCH 5/8] init: " kusumi.tomohiro
2017-06-23 22:07 ` [PATCH 6/8] client: " kusumi.tomohiro
2017-06-23 22:08 ` [PATCH 7/8] verify: " kusumi.tomohiro
2017-06-23 22:08 ` [PATCH 8/8] smalloc: " kusumi.tomohiro
2017-06-23 22:20 ` [PATCH 0/8] option/Makefile fix and void* fixups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba12c06-e24f-2af9-f97e-37bd2ebd583d@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.