All of lore.kernel.org
 help / color / mirror / Atom feed
From: Val Packett <val@packett.cool>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: qcom: Add support to skip phy management by USB core
Date: Tue, 8 Sep 2026 19:33:12 -0300	[thread overview]
Message-ID: <cbb4ae94-7862-4d91-b01d-0d7f18d49a45@packett.cool> (raw)
In-Reply-To: <20260723-dwc3-skip-init-quirk-v1-1-97682bb44ebd@oss.qualcomm.com>


On 7/23/26 7:54 AM, Krishna Kurapati wrote:
> DWC3 driver does manage phys itself sufficiently for Qualcomm platforms.
> If xhci-skip-phy-init is not set, the HCD core does a phy_init and phy_
> exit is done only when roothub is being destroyed. Due to this, during
> system suspend in host mode, although phy_exit is done by DWC3 core, the
> init_count on phy is never down to zero since HCD core also did an init.
> consequently causing phy's exit routine to not be called. Hence, add
> support to skip phy management by USB core.
>
> Some Exynos platforms still do rely on USB core for phy_calibrate calls,
> hence disable USB core management for Qualcomm platforms only.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Link to PHY calibrate handling for Exynos platforms:
> https://lore.kernel.org/all/20190829053028.32438-1-m.szyprowski@samsung.com/

Hi,

this was merged into -next a few days ago, and I'm seeing warnings on 
boot now:

[    0.613188] sysfs: cannot create duplicate filename 
'/devices/platform/soc@0/a800000.usb/software_node'
[    0.613195] CPU: 10 UID: 0 PID: 93 Comm: kworker/u49:0 Tainted: G    
     W           7.3.0-rc2-next-20260907-uwu+ #143 PREEMPT(full)
[    0.613197] Tainted: [W]=WARN
[    0.613198] Hardware name: Dell Inc. Latitude 7455/0FK7MX, BIOS 
2.13.0 09/19/2025
[    0.613199] Workqueue: events_unbound deferred_probe_work_func
[    0.613206] Call trace:
[..]
[    0.613226]  device_create_managed_software_node+0xe8/0x108
[    0.613227]  dwc3_qcom_probe+0x5a4/0x7b0

There is indeed already a software node being created in the shared dwc3 
core code.

Could there be any other consequences than a duplicate sysfs path?

Maybe the property should instead be added to all qcom device trees?

Thanks,
~val


  parent reply	other threads:[~2026-09-08 22:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 10:54 [PATCH] usb: dwc3: qcom: Add support to skip phy management by USB core Krishna Kurapati
2026-08-04 23:38 ` Thinh Nguyen
2026-09-08 22:33 ` Val Packett [this message]
2026-09-08 22:43   ` Val Packett
2026-09-09  1:46     ` Thinh Nguyen
2026-09-09  3:07       ` Krishna Kurapati
  -- strict thread matches above, loose matches on Subject: below --
2026-09-14 14:35 Krishna Kurapati
2026-09-23  0:24 ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb4ae94-7862-4d91-b01d-0d7f18d49a45@packett.cool \
    --to=val@packett.cool \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.