Re: [PATCH v2] drm/xe/guc: Demote uncorrectable local error log to info

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 17-09-2026 19:23, Varun Gupta wrote:
> The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
> local, queue-level context termination rather than a global device or
> driver failure. This can be triggered as part of expected recovery flows,
> including intentional fault-injection tests.
> 
> Printing this at ERROR level is too noisy and causes false-positive
> dmesg-warn failures in CI. Switch the log level to INFO, matching the
> adjacent CAT error handler.
> 
> v2:
>    - Also ratelimit the GUC_ID_UNKNOWN to match the CAT error handler.
>      (Himal)
> 
> Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_submit.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index f3ba8abfc228..6144a1767f10 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3487,7 +3487,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>   	guc_id = msg[0];
>   
>   	if (guc_id == GUC_ID_UNKNOWN) {
> -		xe_gt_err(gt, "GuC: Uncorrectable local error with unknown GuC id\n");
> +		xe_gt_err_ratelimited(gt, "GuC: Uncorrectable local error with unknown GuC id\n");
>   		return 0;
>   	}
>   
> @@ -3495,9 +3495,9 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>   	if (unlikely(!q))
>   		return -EPROTO;
>   
> -	xe_gt_err(gt,
> -		  "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> -		  guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
> +	xe_gt_info(gt,
> +		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> +		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
>   

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   	trace_xe_guc_uncorrectable_error(q);
>