From: Marek Vasut <marek.vasut@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mason Yang <masonccyang@mxic.com.tw>,
tpiepho@impinj.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
boris.brezillon@bootlin.com, juliensu@mxic.com.tw,
Geert Uytterhoeven <geert+renesas@glider.be>,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver
Date: Mon, 19 Nov 2018 23:10:04 +0100 [thread overview]
Message-ID: <cbbc3dba-7f85-c6a3-525f-01eb23e50592@gmail.com> (raw)
In-Reply-To: <20181119152735.GB3535@sirena.org.uk>
On 11/19/2018 04:27 PM, Mark Brown wrote:
> On Mon, Nov 19, 2018 at 03:12:00PM +0100, Marek Vasut wrote:
>> On 11/19/2018 11:01 AM, Mason Yang wrote:
>
>>> +++ b/drivers/spi/spi-renesas-rpc.c
>>> @@ -0,0 +1,750 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// Copyright (C) 2018 ~ 2019 Renesas Solutions Corp.
>>> +// Copyright (C) 2018 Macronix International Co., Ltd.
>>> +//
>>> +// R-Car D3 RPC SPI/QSPI/Octa driver
>>> +//
>>> +// Authors:
>>> +// Mason Yang <masonccyang@mxic.com.tw>
>>> +//
>
>> Fix multiline comment please.
>
> The SPDX header needs to be C++ style so I push people to make the whole
> block C++ otherwise it looks messy.
OK, I'm not gonna wrestle you on this, but I think it looks horrible ;-)
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-11-20 8:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:01 [PATCH 0/2] spi: Add Renesas R-Car D3 RPC SPI driver Mason Yang
2018-11-19 10:01 ` [PATCH 1/2] spi: Add Renesas R-Car RPC SPI controller driver Mason Yang
2018-11-19 14:12 ` Marek Vasut
2018-11-19 15:27 ` Mark Brown
2018-11-19 22:10 ` Marek Vasut [this message]
2018-11-20 13:26 ` Mark Brown
2018-11-20 13:33 ` Marek Vasut
2018-11-20 7:23 ` masonccyang
2018-11-20 13:09 ` Marek Vasut
2018-11-20 13:32 ` Boris Brezillon
2018-11-20 13:35 ` Marek Vasut
2018-11-23 0:45 ` masonccyang
2018-11-23 13:34 ` Marek Vasut
2018-11-23 13:34 ` Marek Vasut
2018-11-20 2:04 ` kbuild test robot
2018-11-20 5:49 ` kbuild test robot
2018-11-20 8:01 ` Geert Uytterhoeven
2018-11-20 8:10 ` Boris Brezillon
2018-11-20 9:27 ` masonccyang
2018-11-20 9:23 ` masonccyang
2018-11-19 10:01 ` [PATCH 2/2] dt-binding: spi: Document Renesas R-Car RPC controller bindings Mason Yang
2018-11-19 13:49 ` Marek Vasut
2018-11-19 14:10 ` Boris Brezillon
2018-11-19 14:14 ` Marek Vasut
2018-11-19 14:43 ` Boris Brezillon
2018-11-19 15:12 ` Marek Vasut
2018-11-19 15:21 ` Boris Brezillon
2018-11-19 22:11 ` Marek Vasut
2018-11-19 22:19 ` Boris Brezillon
2018-11-19 22:22 ` Marek Vasut
2018-11-19 22:25 ` Boris Brezillon
2018-11-19 22:29 ` Marek Vasut
2018-11-19 22:31 ` Boris Brezillon
2018-11-20 5:42 ` masonccyang
2018-11-20 12:57 ` Marek Vasut
2018-11-21 0:53 ` masonccyang
2018-11-21 1:51 ` Marek Vasut
2018-11-20 8:07 ` Geert Uytterhoeven
2018-11-20 13:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbbc3dba-7f85-c6a3-525f-01eb23e50592@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=masonccyang@mxic.com.tw \
--cc=tpiepho@impinj.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.