From: Yash Shinde <Yash.Shinde@windriver.com>
To: Randy MacLeod <randy.macleod@windriver.com>,
openembedded-core@lists.openembedded.org
Cc: Naveen.Gowda@windriver.com, Sundeep.Kokkonda@windriver.com
Subject: Re: [PATCH] cargo: Increase RUST_MIN_STACK size to avoid SIGSEGV in DEBUG builds only.
Date: Thu, 14 Nov 2024 16:32:50 +0530 [thread overview]
Message-ID: <cbc0bcd9-ef88-4fa8-9595-e69d8a794c47@windriver.com> (raw)
In-Reply-To: <35d5f2ec-4281-4be1-8040-829dbbdc0d58@windriver.com>
On 31-10-2024 19:32, Randy MacLeod wrote:
>
> We discussed this issue and agreed that since it doesn't affect YP AB
> since there are no DEBUG builds done there
> and more importantly since it's really a work-around rather than a
> fix, we'll continue to work with upstream p384
> crate owners to resolve the issue. Forcing users to change the stack
> size, even for debug builds, is not a good policy
> and hopefully some of the code-generation tools that are inputs to
> p384 can be adjusted to reduce stack usage.
>
> ../Randy
>
This issue is now fixed by removing unused mut variables in p384 crate
and thus reducing the codegen.
(https://github.com/RustCrypto/elliptic-curves/commit/7652c5842cde60acc1e739ebbba34614cb158f8b)
The current stable version of the RustCrypto p384 crate is v0.13.0,
which is also the default version for building with Rust.
But, the fix has been merged into the pre-release versions
"p384/v0.14.0-pre.2" and "p384/v0.14.0-pre.1." of p384 crate.
I have opened a discussion thread in p384 crate:
https://github.com/RustCrypto/elliptic-curves/discussions/1102
to ask the crate developers either to update p384 crate into new version
with the fix, or backport it to "v.0.13.0".
We can wait for upstream unless someone wants to merge a patch for
master now.
Let me know your thoughts on this.
Regards,
Yash
next prev parent reply other threads:[~2024-11-14 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:16 [PATCH] cargo: Increase RUST_MIN_STACK size to avoid SIGSEGV in DEBUG builds only Yash.Shinde
2024-10-30 11:20 ` Yash Shinde
2024-10-30 14:24 ` Randy MacLeod
2024-10-31 9:35 ` Yash Shinde
2024-10-31 14:02 ` Randy MacLeod
2024-11-14 11:02 ` Yash Shinde [this message]
2024-11-14 12:01 ` [OE-core] " Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc0bcd9-ef88-4fa8-9595-e69d8a794c47@windriver.com \
--to=yash.shinde@windriver.com \
--cc=Naveen.Gowda@windriver.com \
--cc=Sundeep.Kokkonda@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.