* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
@ 2005-07-05 21:27 ` Greg KH
2005-07-05 22:11 ` Alexey Dobriyan
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2005-07-05 21:27 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> This patch changes the pci_find_device to pci_get_device.
> Please correct me, whether it's wrong. It is my first patch. :)
>
> Signed-off-by: Rodrigo Nascimento <underscore0x5f@gmail.com>
>
> # diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> /usr/src/linux-kj/drivers/scsi/qla1280.c
> --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> 16:33:05.000000000 -0300
Content looks good, but the patch is linwrapped and all of the tabs are
converted to spaces, making it impossible to apply. And it's made at
the wrong patch level :(
Good luck,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
2005-07-05 21:27 ` Greg KH
@ 2005-07-05 22:11 ` Alexey Dobriyan
2005-07-05 22:45 ` Domen Puncer
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Alexey Dobriyan @ 2005-07-05 22:11 UTC (permalink / raw)
To: kernel-janitors
On Wednesday 06 July 2005 01:13, Rodrigo Nascimento wrote:
> This patch changes the pci_find_device to pci_get_device.
> Please correct me, whether it's wrong. It is my first patch. :)
Thanks. It looks good except trivially fixable issues:
1. Long lines are wrapped.
2. Tabs are converted to spaces.
If you're using Gmail web-interface and copy-pasting patch, stop now. ;-) If
you're using email program, tune it a little.
> #
You can hack in your home directory. Much safer. You need root privileges
only when installing new kernel.
> diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> /usr/src/linux-kj/drivers/scsi/qla1280.c
> --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> 16:33:05.000000000 -0300
> +++ /usr/src/linux-kj/drivers/scsi/qla1280.c 2005-07-05
> 17:55:24.000000000 -0300
Patches are supposed to be "patch -p1" compliant. Paths should be
relative:
--- linux/drivers/scsi/qla1280.c
+++ linux-kj/drivers/scsi/qla1280.c
> @@ -1196,7 +1196,7 @@ qla1280_detect(Scsi_Host_Template *templ
> #endif
>
> /* First Initialize QLA12160 on PCI Bus 1 Dev 2 */
> - while ((pdev = pci_find_device(id->vendor, id->device, pdev))) {
> + while ((pdev = pci_get_device(id->vendor, id->device, pdev))) {
> if (pdev->bus->number = 1 && PCI_SLOT(pdev->devfn) = 2) {
> if (!qla1280_probe_one(pdev, id))
> num_hosts++;
> @@ -1206,7 +1206,7 @@ qla1280_detect(Scsi_Host_Template *templ
> pdev = NULL;
> /* Try and find each different type of adapter we support */
> for (id = &qla1280_pci_tbl[0]; id->device; id++) {
> - while ((pdev = pci_find_device(id->vendor, id->device, pdev))) {
> + while ((pdev = pci_get_device(id->vendor, id->device, pdev))) {
> /*
> * skip QLA12160 already initialized on
> * PCI Bus 1 Dev 2 since we already initialized
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
2005-07-05 21:27 ` Greg KH
2005-07-05 22:11 ` Alexey Dobriyan
@ 2005-07-05 22:45 ` Domen Puncer
2005-07-05 22:55 ` Greg KH
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Domen Puncer @ 2005-07-05 22:45 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On 05/07/05 14:27 -0700, Greg KH wrote:
> On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> > This patch changes the pci_find_device to pci_get_device.
> > Please correct me, whether it's wrong. It is my first patch. :)
> >
> > Signed-off-by: Rodrigo Nascimento <underscore0x5f@gmail.com>
> >
> > # diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> > /usr/src/linux-kj/drivers/scsi/qla1280.c
> > --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> > 16:33:05.000000000 -0300
>
> Content looks good, but the patch is linwrapped and all of the tabs are
> converted to spaces, making it impossible to apply. And it's made at
> the wrong patch level :(
Is pci_dev_put() not needed? Why not?
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
` (2 preceding siblings ...)
2005-07-05 22:45 ` Domen Puncer
@ 2005-07-05 22:55 ` Greg KH
2005-07-06 8:39 ` Christoph Hellwig
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2005-07-05 22:55 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Wed, Jul 06, 2005 at 12:45:10AM +0200, Domen Puncer wrote:
> On 05/07/05 14:27 -0700, Greg KH wrote:
> > On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> > > This patch changes the pci_find_device to pci_get_device.
> > > Please correct me, whether it's wrong. It is my first patch. :)
> > >
> > > Signed-off-by: Rodrigo Nascimento <underscore0x5f@gmail.com>
> > >
> > > # diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> > > /usr/src/linux-kj/drivers/scsi/qla1280.c
> > > --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> > > 16:33:05.000000000 -0300
> >
> > Content looks good, but the patch is linwrapped and all of the tabs are
> > converted to spaces, making it impossible to apply. And it's made at
> > the wrong patch level :(
>
> Is pci_dev_put() not needed? Why not?
Where would you place it?
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
` (3 preceding siblings ...)
2005-07-05 22:55 ` Greg KH
@ 2005-07-06 8:39 ` Christoph Hellwig
2005-07-06 8:50 ` Domen Puncer
2005-07-06 14:35 ` Rodrigo Nascimento
6 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2005-07-06 8:39 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> This patch changes the pci_find_device to pci_get_device.
> Please correct me, whether it's wrong. It is my first patch. :)
The code is in a 2.4.x ifdef block, for 2.6 it uses the proper pci_driver
model.
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
` (4 preceding siblings ...)
2005-07-06 8:39 ` Christoph Hellwig
@ 2005-07-06 8:50 ` Domen Puncer
2005-07-06 14:35 ` Rodrigo Nascimento
6 siblings, 0 replies; 8+ messages in thread
From: Domen Puncer @ 2005-07-06 8:50 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On 05/07/05 15:55 -0700, Greg KH wrote:
> On Wed, Jul 06, 2005 at 12:45:10AM +0200, Domen Puncer wrote:
> > On 05/07/05 14:27 -0700, Greg KH wrote:
> > > On Tue, Jul 05, 2005 at 06:13:10PM -0300, Rodrigo Nascimento wrote:
> > > > This patch changes the pci_find_device to pci_get_device.
> > > > Please correct me, whether it's wrong. It is my first patch. :)
> > > >
> > > > Signed-off-by: Rodrigo Nascimento <underscore0x5f@gmail.com>
> > > >
> > > > # diff -urpN /usr/src/linux/drivers/scsi/qla1280.c
> > > > /usr/src/linux-kj/drivers/scsi/qla1280.c
> > > > --- /usr/src/linux/drivers/scsi/qla1280.c 2005-06-22
> > > > 16:33:05.000000000 -0300
> > >
> > > Content looks good, but the patch is linwrapped and all of the tabs are
> > > converted to spaces, making it impossible to apply. And it's made at
> > > the wrong patch level :(
> >
> > Is pci_dev_put() not needed? Why not?
>
> Where would you place it?
Fail path of qla1280_probe_one(), qla1280_remove_one().
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of
2005-07-05 21:13 [KJ] [PATCH] drivers/scsi/qla1280.c: pci_get_device instead of Rodrigo Nascimento
` (5 preceding siblings ...)
2005-07-06 8:50 ` Domen Puncer
@ 2005-07-06 14:35 ` Rodrigo Nascimento
6 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Nascimento @ 2005-07-06 14:35 UTC (permalink / raw)
To: kernel-janitors
Mr. Hellwig,
It's true, sorry I need to have more attetion....
Thanks,
--
Rodrigo Nascimento
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 8+ messages in thread