From: Mudit Sharma <muditsharma.info@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
jic23@kernel.org, lars@metafoo.de, krzk+dt@kernel.org,
conor+dt@kernel.org, robh@kernel.org
Cc: linux-kernel@vger.kernel.org, mazziesaccount@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Ivan Orlov <ivan.orlov0322@gmail.com>
Subject: Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor
Date: Sat, 20 Jul 2024 19:29:28 +0100 [thread overview]
Message-ID: <cbefce0e-e5f9-400c-a387-f60609f5bba3@gmail.com> (raw)
In-Reply-To: <2505dee2-c503-4566-a4ef-73103da9479d@gmail.com>
On 19/07/2024 17:02, Javier Carrasco wrote:
> On 19/07/2024 00:02, Mudit Sharma wrote:
>> Add support for BH1745, which is an I2C colour sensor with red, green,
>> blue and clear channels. It has a programmable active low interrupt
>> pin. Interrupt occurs when the signal from the selected interrupt
>> source channel crosses set interrupt threshold high or low level.
>>
>> Interrupt source for the device can be configured by enabling the
>> corresponding event. Interrupt latch is always enabled when setting
>> up interrupt.
>>
>> Add myself as the maintainer for this driver in MAINTAINERS.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com>
>> Reviewed-by: Ivan Orlov <ivan.orlov0322@gmail.com>
>> Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>
> Hi Mudit,
>
> a couple of nitpicks inline.
>
> ...
>
>
> Typo in debug message: corresponding. I would recommend you to pass
> codespell to checkpatch. It will often catch such things.
>
Hi Javier,
Thank you for reviewing and the recommendation. Will keep in mind for
future patches.
Best regards,
Mudit Sharma
>> + dev_dbg(dev, "No corrosponding gain for requested integration time\n");
>> + return ret;
>> + }
>> +
next prev parent reply other threads:[~2024-07-20 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 22:02 [PATCH v8 1/2] dt-bindings: iio: light: ROHM BH1745 Mudit Sharma
2024-07-18 22:02 ` [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor Mudit Sharma
2024-07-19 16:02 ` Javier Carrasco
2024-07-20 18:29 ` Mudit Sharma [this message]
2024-07-20 16:29 ` Jonathan Cameron
2024-07-20 18:25 ` Mudit Sharma
2024-08-05 10:28 ` Matti Vaittinen
2024-08-06 20:45 ` Mudit Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbefce0e-e5f9-400c-a387-f60609f5bba3@gmail.com \
--to=muditsharma.info@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.