From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D071C43461 for ; Wed, 19 May 2021 10:38:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E04B56124C for ; Wed, 19 May 2021 10:38:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E04B56124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=32uvUgVRqkKY+QHe0Aww/EjSSvo0wxPCJYszx5IVmpI=; b=FeyFYANa2oFtQxhKvxsiPFroB p+zYdWUCQkjhQUi35gqAlpj50CuEWohUp+aimPMHvoIxOyCJEA97eVKFoh8dvrfPw7GH2u/k4FLq2 GDDA86mIDnA0TXPDdacg0Cri/ec8s/qs0AYg1D5i8OcXehiWxMhrHboRCZdaMvWyfVJUVWnQSOLc0 vAe5gd7OT2vlzGOxTkVK9KwLBhhiJubM6OcRzhIxsbHODRi4ewJxY/mDmeXjx2HcVlpgVo8YqUtYW Tb1khvdL3GoqJb+9lC/4LPhSADoJkfYs04jYVJrTxPVjOmetOr7B6NRZdc2n3FRfDYzSKNd8qVqtr 5TR96XfHA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljJac-003bgo-5S; Wed, 19 May 2021 10:38:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljJaQ-003bfo-Q6 for linux-rockchip@desiato.infradead.org; Wed, 19 May 2021 10:37:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=xzuESJ+k+2y7Nhli/8VjnG+9Q7+whBxw6GBhacmD5FA=; b=hTV/rFoSRLXPCa/Wr9nOLaZ2jm pj8c73fu0lktHB7q5oiqAfk+L9URzDIZh5LpV9L9ftDYhY6w+2h4r/eUupio/gsPjcSe7uoyokXcS CCquCgZwSucU+CUku090ptxAINxkEmZaWkcOuHrGyotfKJKZC9Tuc1wnuqdtiCzBOedSv73v9tjHB jd4w5IN3ppaQmmUf5x/JWQ6Yvek1BEZmmW9oycu1YuW5XklHFJDkMlLw6XMUOXuX9Qs6DHt626Mm7 sUPW503XCA7QBZ8y6AQ8HI48mm6ppO0eXKTbihvYRwvFk6xpUcxBcw6PrLfifa+PU/LkkGEFgBVpq km2K++qw==; Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljJaO-00FMLj-3C for linux-rockchip@lists.infradead.org; Wed, 19 May 2021 10:37:57 +0000 Received: by mail-wm1-x331.google.com with SMTP id f19-20020a05600c1553b02901794fafcfefso2518596wmg.2 for ; Wed, 19 May 2021 03:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xzuESJ+k+2y7Nhli/8VjnG+9Q7+whBxw6GBhacmD5FA=; b=qyZnyuji6WAA/FyI/zYJiASunjp824/6ZpSGR24DJkEr1W/446xOfaSzbTFSTQSigD XL0BBC5q0saLHLGZOhjXuCvXdJBKBlREXp71VHXntN0hyVVTqP0wp90VkkflUgqwzC3M aXEndXp9KYPgUMmvMQrDXl8U69ueoqNwJSsUhg3AvfMCVbmgJRE/8nyaSNk2QYuaMPsu nDy/5xSwAia7uHJqf55WYBAoRmEbI2H/gI7zlHZ07izNwrKj20r+DkmDwTTur5hC6bXJ MeiJE8DONPY9Zo4tkUV0MnlUrI4T5z3TAV7zfCzqPVIeDeSxeOjbvUHXONDNjBYZAp5R +o3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xzuESJ+k+2y7Nhli/8VjnG+9Q7+whBxw6GBhacmD5FA=; b=axbIeaL3WuBAhFkNsFtCbf9OgZbtT+UtuYB1H8LOp1EsE/w1SBpaF7aX5BAMPQOx67 5pmWs27RxE744bM6xozKUQ2UNNi/6PV9KuUH52Znpqm8jL1kd3Z5rjE+fDsXfDBbceYs uhCH/ou3LVH7XTopjlmrI6I95uJrzDoKBj7VbRAmSY9XGfIZYNHeeWUYER6tD6KNbTSc c+Wns6R8ku2wT1p5BI6SdYGBQCq2t45pSLw3n4TrN2pcYHATHHfVuyKxseRe/Ks9L1Bk d77QF4ucg7TEMjdnKPV4+5slji/hGjkLcLBpD8l6I/Eq5/JUHXa9GKy1UAG0DcHqdG9F jabg== X-Gm-Message-State: AOAM533RCHKf9ixVwdvei5zh3O55cNoytr36iiRvZagu/yu46DF5Kxu8 EZ17p0Tk0Br/ofJi4NUtdpTnDhhjb4pWAA== X-Google-Smtp-Source: ABdhPJxRhhLUGT9FkUiySw8DyA1imc0Ea6Q8ODsVyJcs+hJMMhvPHZZWIBH1wdZ+2qBZB2LL3p4YKA== X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr10117550wmm.138.1621420673557; Wed, 19 May 2021 03:37:53 -0700 (PDT) Received: from ?IPv6:2003:ea:8f38:4600:e5dc:6577:6b94:e9e7? (p200300ea8f384600e5dc65776b94e9e7.dip0.t-ipconnect.de. [2003:ea:8f38:4600:e5dc:6577:6b94:e9e7]) by smtp.googlemail.com with ESMTPSA id v18sm30207587wro.18.2021.05.19.03.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 03:37:52 -0700 (PDT) Subject: Re: [PATCH] net: phy: add driver for Motorcomm yt8511 phy To: Leon Romanovsky , Peter Geis Cc: Andrew Lunn , Russell King , "David S . Miller" , Jakub Kicinski , Linux Kernel Mailing List , Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." References: <20210511214605.2937099-1-pgwipeout@gmail.com> From: Heiner Kallweit Message-ID: Date: Wed, 19 May 2021 12:37:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_033756_177169_4C5D62FA X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 19.05.2021 10:18, Leon Romanovsky wrote: > On Tue, May 18, 2021 at 08:20:03PM -0400, Peter Geis wrote: >> On Tue, May 18, 2021 at 4:59 AM Leon Romanovsky wrote: >>> >>> On Tue, May 11, 2021 at 05:46:06PM -0400, Peter Geis wrote: >>>> Add a driver for the Motorcomm yt8511 phy that will be used in the >>>> production Pine64 rk3566-quartz64 development board. >>>> It supports gigabit transfer speeds, rgmii, and 125mhz clk output. >>>> >>>> Signed-off-by: Peter Geis >>>> --- >>>> MAINTAINERS | 6 +++ >>>> drivers/net/phy/Kconfig | 6 +++ >>>> drivers/net/phy/Makefile | 1 + >>>> drivers/net/phy/motorcomm.c | 85 +++++++++++++++++++++++++++++++++++++ >>>> 4 files changed, 98 insertions(+) >>>> create mode 100644 drivers/net/phy/motorcomm.c >>> >>> <...> >>> >>>> +static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = { >>>> + { PHY_ID_MATCH_EXACT(PHY_ID_YT8511) }, >>>> + { /* sentinal */ } >>>> +} >>> >>> Why is this "__maybe_unused"? This *.c file doesn't have any compilation option >>> to compile part of it. >>> >>> The "__maybe_unused" is not needed in this case. >> >> I was simply following convention, for example the realtek.c, >> micrel.c, and smsc.c drivers all have this as well. > > Maybe they have a reason, but this specific driver doesn't have such. > It's used like this: MODULE_DEVICE_TABLE(mdio, ); And MODULE_DEVICE_TABLE is a no-op if MODULE isn't defined: #ifdef MODULE /* Creates an alias so file2alias.c can find device table. */ #define MODULE_DEVICE_TABLE(type, name) \ extern typeof(name) __mod_##type##__##name##_device_table \ __attribute__ ((unused, alias(__stringify(name)))) #else /* !MODULE */ #define MODULE_DEVICE_TABLE(type, name) #endif In this case the table is unused. > Thanks > >> >>> >>> Thanks _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCA9C433ED for ; Wed, 19 May 2021 10:38:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EE8561006 for ; Wed, 19 May 2021 10:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348185AbhESKjR (ORCPT ); Wed, 19 May 2021 06:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhESKjP (ORCPT ); Wed, 19 May 2021 06:39:15 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0816AC06175F; Wed, 19 May 2021 03:37:55 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id s5-20020a7bc0c50000b0290147d0c21c51so3037817wmh.4; Wed, 19 May 2021 03:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xzuESJ+k+2y7Nhli/8VjnG+9Q7+whBxw6GBhacmD5FA=; b=qyZnyuji6WAA/FyI/zYJiASunjp824/6ZpSGR24DJkEr1W/446xOfaSzbTFSTQSigD XL0BBC5q0saLHLGZOhjXuCvXdJBKBlREXp71VHXntN0hyVVTqP0wp90VkkflUgqwzC3M aXEndXp9KYPgUMmvMQrDXl8U69ueoqNwJSsUhg3AvfMCVbmgJRE/8nyaSNk2QYuaMPsu nDy/5xSwAia7uHJqf55WYBAoRmEbI2H/gI7zlHZ07izNwrKj20r+DkmDwTTur5hC6bXJ MeiJE8DONPY9Zo4tkUV0MnlUrI4T5z3TAV7zfCzqPVIeDeSxeOjbvUHXONDNjBYZAp5R +o3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xzuESJ+k+2y7Nhli/8VjnG+9Q7+whBxw6GBhacmD5FA=; b=CCSiRVjvzFLHWunjc407FhAgEmfvzqba+mZWK67WnZqT6Lk4ez+UofxdehP6bWzrLk 4VUdmrZ8RjwbJVE3bJgZGmt84MLmDncT88su+0m+jrCvy47wUiLThulXT5jdwt1qeaZ5 a3dyqoojYrjhUDVvdVMoR/sA0wY2ucaf/BZck672Ta6/s+rIZ5bL5ECtXUtfxQ76wA9N 8KvR50/yzfYu3w+k1DPY2SIedHa0SOh8i2ac7n5QLBAt9MfOADa5pzZsPeD+h6R+ZL0U y/FJHyosNaTrCavglhGNgFXEQr0nCVNOm0MqmQQGkZWF3UUC+lQMCx0iCHSgZOKCVTEB AcOQ== X-Gm-Message-State: AOAM532h3gCcHUYkh7y8GdNQnXlFCmePZCY0VxdLdcWzGXy4Sf20zow9 WrYW0JgVv8HdtBCbF//NwM0= X-Google-Smtp-Source: ABdhPJxRhhLUGT9FkUiySw8DyA1imc0Ea6Q8ODsVyJcs+hJMMhvPHZZWIBH1wdZ+2qBZB2LL3p4YKA== X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr10117550wmm.138.1621420673557; Wed, 19 May 2021 03:37:53 -0700 (PDT) Received: from ?IPv6:2003:ea:8f38:4600:e5dc:6577:6b94:e9e7? (p200300ea8f384600e5dc65776b94e9e7.dip0.t-ipconnect.de. [2003:ea:8f38:4600:e5dc:6577:6b94:e9e7]) by smtp.googlemail.com with ESMTPSA id v18sm30207587wro.18.2021.05.19.03.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 03:37:52 -0700 (PDT) Subject: Re: [PATCH] net: phy: add driver for Motorcomm yt8511 phy To: Leon Romanovsky , Peter Geis Cc: Andrew Lunn , Russell King , "David S . Miller" , Jakub Kicinski , Linux Kernel Mailing List , Linux Kernel Network Developers , "open list:ARM/Rockchip SoC..." References: <20210511214605.2937099-1-pgwipeout@gmail.com> From: Heiner Kallweit Message-ID: Date: Wed, 19 May 2021 12:37:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.05.2021 10:18, Leon Romanovsky wrote: > On Tue, May 18, 2021 at 08:20:03PM -0400, Peter Geis wrote: >> On Tue, May 18, 2021 at 4:59 AM Leon Romanovsky wrote: >>> >>> On Tue, May 11, 2021 at 05:46:06PM -0400, Peter Geis wrote: >>>> Add a driver for the Motorcomm yt8511 phy that will be used in the >>>> production Pine64 rk3566-quartz64 development board. >>>> It supports gigabit transfer speeds, rgmii, and 125mhz clk output. >>>> >>>> Signed-off-by: Peter Geis >>>> --- >>>> MAINTAINERS | 6 +++ >>>> drivers/net/phy/Kconfig | 6 +++ >>>> drivers/net/phy/Makefile | 1 + >>>> drivers/net/phy/motorcomm.c | 85 +++++++++++++++++++++++++++++++++++++ >>>> 4 files changed, 98 insertions(+) >>>> create mode 100644 drivers/net/phy/motorcomm.c >>> >>> <...> >>> >>>> +static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = { >>>> + { PHY_ID_MATCH_EXACT(PHY_ID_YT8511) }, >>>> + { /* sentinal */ } >>>> +} >>> >>> Why is this "__maybe_unused"? This *.c file doesn't have any compilation option >>> to compile part of it. >>> >>> The "__maybe_unused" is not needed in this case. >> >> I was simply following convention, for example the realtek.c, >> micrel.c, and smsc.c drivers all have this as well. > > Maybe they have a reason, but this specific driver doesn't have such. > It's used like this: MODULE_DEVICE_TABLE(mdio, ); And MODULE_DEVICE_TABLE is a no-op if MODULE isn't defined: #ifdef MODULE /* Creates an alias so file2alias.c can find device table. */ #define MODULE_DEVICE_TABLE(type, name) \ extern typeof(name) __mod_##type##__##name##_device_table \ __attribute__ ((unused, alias(__stringify(name)))) #else /* !MODULE */ #define MODULE_DEVICE_TABLE(type, name) #endif In this case the table is unused. > Thanks > >> >>> >>> Thanks