From: Segher Boessenkool <segher@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port
Date: Wed, 12 Sep 2007 16:10:09 +0200 [thread overview]
Message-ID: <cbff3b332b53f61721a8e14472347b98@kernel.crashing.org> (raw)
In-Reply-To: <AC5C6EF4-EE8E-487F-BF45-3653A5C2617D@kernel.crashing.org>
>>> + i8259: interrupt-controller@20 {
>>> + reg = <1 20 2
>>> + 1 a0 2
>>> + 1 4d0 2>;
>>> + clock-frequency = <0>;
>>
>> Hrm.. what is clock-frequency for on an i8259? I see that other 8259
>> descriptions have this as well, so it's not a problem with this patch
>> specifically.
>
> Its a copy-paste thing so I don't know.
If your bootwrapper doesn't fill in this value, you should get rid
of this property -- better to have no value than to have the wrong
value, esp. since it's probably unused anyway.
Segher
next prev parent reply other threads:[~2007-09-12 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 19:37 [PATCH v3] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port Kumar Gala
2007-09-12 3:11 ` David Gibson
2007-09-12 3:33 ` Kumar Gala
2007-09-12 3:53 ` David Gibson
2007-09-12 14:00 ` Segher Boessenkool
2007-09-12 15:08 ` MDIO & phy device tree bindings (was Re: [PATCH v3] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port) Kumar Gala
2007-09-12 15:13 ` [PATCH v3] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port Kumar Gala
2007-09-12 14:10 ` Segher Boessenkool [this message]
2007-09-13 3:27 ` Kumar Gala
2007-09-12 13:36 ` Segher Boessenkool
2007-09-13 3:28 ` Kumar Gala
2007-09-13 4:21 ` David Gibson
2007-09-13 17:06 ` Segher Boessenkool
2007-09-13 18:24 ` Kumar Gala
2007-09-13 22:30 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbff3b332b53f61721a8e14472347b98@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.