Re: [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

[Jaehoon Chung <jh80.chung@gmail.com>]

Hi Simon,

On 2/27/22 03:36, Simon Glass wrote:
> Hi Jaehoon,
>
> On Tue, 8 Feb 2022 at 16:42, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> On 1/29/22 07:42, Alper Nebi Yasak wrote:
>>> On RK3568, a register bit must be set to enable Enhanced Strobe.
>>> However, it appears that the address of this register may differ from
>>> vendor to vendor and should be read from the underlying MMC IP. Let the
>>> Rockchip SDHCI driver read this address and set the relevant bit when
>>> Enhanced Strobe configuration is requested.
>>>
>>> Additionally, a bit signifying that the connected hardware is an eMMC
>>> chip must be set to enable Data Strobe for HS400 and HS400ES modes. Also
>>> make the driver set this bit as appropriate.
>>>
>>> This is partly ported from Linux's Synopsys DWC MSHC driver which
>>> happens to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in
>>> Linux tree).
>>>
>>> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> As you mentioned, if someone test this on RK3568 board, it will be more better.
> That does not seem to have happened, but it will likely happen when it
> is applied.

Agreed. I will apply this on u-boot-mmc.

Best Regards,
Jaehoon Chung

>
> Regards,
> Simon