From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org,
Li Li <dualli@chromium.org>,
donald.hunter@gmail.com, sdf@fomichev.me, almasrymina@google.com
Subject: Re: [PATCH net] netdev: avoid CFI problems with sock priv helpers
Date: Thu, 16 Jan 2025 13:20:11 +0100 [thread overview]
Message-ID: <cc0541ea-00e6-4444-ae90-a6cbeec3f6d9@redhat.com> (raw)
In-Reply-To: <20250115161436.648646-1-kuba@kernel.org>
On 1/15/25 5:14 PM, Jakub Kicinski wrote:
> Li Li reports that casting away callback type may cause issues
> for CFI. Let's generate a small wrapper for each callback,
> to make sure compiler sees the anticipated types.
>
> Reported-by: Li Li <dualli@chromium.org>
> Link: https://lore.kernel.org/CANBPYPjQVqmzZ4J=rVQX87a9iuwmaetULwbK_5_3YWk2eGzkaA@mail.gmail.com
> Fixes: 170aafe35cb9 ("netdev: support binding dma-buf to netdevice")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: sdf@fomichev.me
> CC: almasrymina@google.com
FTR, I took the liberty of applying this patch before the 24H grace
period to fit todays net PR and avoid shipping a 6.13 final with a known
serious issue.
/P
next prev parent reply other threads:[~2025-01-16 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 16:14 [PATCH net] netdev: avoid CFI problems with sock priv helpers Jakub Kicinski
2025-01-15 17:01 ` Mina Almasry
2025-01-16 12:20 ` Paolo Abeni [this message]
2025-01-16 12:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0541ea-00e6-4444-ae90-a6cbeec3f6d9@redhat.com \
--to=pabeni@redhat.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dualli@chromium.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.