All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Crofts <crofts@kernel.org>
To: Siqi Chen <chensiqi@uniontech.com>,
	jagathjog1996@gmail.com, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: bmi323: check i2c_transfer() return value
Date: Thu, 19 Nov 2026 10:30:28 +0100	[thread overview]
Message-ID: <cc270a65-985a-45ad-bfdf-b205cf9ff86b@kernel.org> (raw)
In-Reply-To: <20261119070837.3844364-1-chensiqi@uniontech.com>

On 19-Nov-26 8:08, Siqi Chen wrote:
> i2c_transfer() returns the number of messages transferred or a negative
> error code. The BMI323 I2C read path only checks for negative values and
> maps all errors to -EIO.
> 
> If only the register-address message is transferred, the function copies
> data from the receive buffer and reports success even though the read
> message was not completed.
> 
> Require both messages to be transferred, preserve negative error codes,
> and return -EIO for a short transfer.
> 
> OpenCode was used to identify the issue and draft the code and changelog.
> 
> Compile-tested with CONFIG_BMI323_I2C=m using:
> 
>   make O=/tmp/opencode/linux-build-bmi323 W=1 \
>        drivers/iio/imu/bmi323/bmi323_i2c.o
> 
> No hardware or I2C fault-injection testing was performed.

Also the testing info should go under the ---, as it's compile tested only.

-- 
Kind regards,
Joshua Crofts


  parent reply	other threads:[~2026-11-19  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  7:08 [PATCH] iio: imu: bmi323: check i2c_transfer() return value Siqi Chen
2026-11-19  9:27 ` Joshua Crofts
2026-11-19  9:30 ` Joshua Crofts [this message]
2026-11-20  1:55   ` Siqi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc270a65-985a-45ad-bfdf-b205cf9ff86b@kernel.org \
    --to=crofts@kernel.org \
    --cc=andy@kernel.org \
    --cc=chensiqi@uniontech.com \
    --cc=dlechner@baylibre.com \
    --cc=jagathjog1996@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.