Re: [PATCH v2 2/2] block: Enforce power-of-2 physical block size

[Damien Le Moal <dlemoal@kernel.org>]

On 7/29/25 18:14, John Garry wrote:
> The merging/splitting code and other queue limits checking depends on the
> physical block size being a power-of-2, so enforce it.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
>  block/blk-settings.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/block/blk-settings.c b/block/blk-settings.c
> index fa53a330f9b99..5ae0a253e43fd 100644
> --- a/block/blk-settings.c
> +++ b/block/blk-settings.c
> @@ -274,6 +274,10 @@ int blk_validate_limits(struct queue_limits *lim)
>  	}
>  	if (lim->physical_block_size < lim->logical_block_size)
>  		lim->physical_block_size = lim->logical_block_size;
> +	else if (!is_power_of_2(lim->physical_block_size)) {
> +		pr_warn("Invalid physical block size (%d)\n", lim->physical_block_size);

Nit: format should use %u

> +		return -EINVAL;
> +	}

Nit: Add the curly brackets to the if part too.

Other than that, looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

>  
>  	/*
>  	 * The minimum I/O size defaults to the physical block size unless


-- 
Damien Le Moal
Western Digital Research