Re: [RESEND] drm/i915/sdvo: use the i2c bus locking functions

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 13 May 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, May 13, 2026 at 11:01:03AM +0300, Jani Nikula wrote:
>> Use i2c_lock_bus(), i2c_trylock_bus(), and i2c_unlock_bus() instead of
>> poking at i2c adapter's lock_ops directly.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed to din.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
>> index 23c511a9a2ad..ba54c90828f4 100644
>> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
>> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
>> @@ -3319,7 +3319,7 @@ static void proxy_lock_bus(struct i2c_adapter *adapter,
>>  	struct intel_sdvo_ddc *ddc = adapter->algo_data;
>>  	struct intel_sdvo *sdvo = ddc->sdvo;
>>  
>> -	sdvo->i2c->lock_ops->lock_bus(sdvo->i2c, flags);
>> +	i2c_lock_bus(sdvo->i2c, flags);
>>  }
>>  
>>  static int proxy_trylock_bus(struct i2c_adapter *adapter,
>> @@ -3328,7 +3328,7 @@ static int proxy_trylock_bus(struct i2c_adapter *adapter,
>>  	struct intel_sdvo_ddc *ddc = adapter->algo_data;
>>  	struct intel_sdvo *sdvo = ddc->sdvo;
>>  
>> -	return sdvo->i2c->lock_ops->trylock_bus(sdvo->i2c, flags);
>> +	return i2c_trylock_bus(sdvo->i2c, flags);
>>  }
>>  
>>  static void proxy_unlock_bus(struct i2c_adapter *adapter,
>> @@ -3337,7 +3337,7 @@ static void proxy_unlock_bus(struct i2c_adapter *adapter,
>>  	struct intel_sdvo_ddc *ddc = adapter->algo_data;
>>  	struct intel_sdvo *sdvo = ddc->sdvo;
>>  
>> -	sdvo->i2c->lock_ops->unlock_bus(sdvo->i2c, flags);
>> +	i2c_unlock_bus(sdvo->i2c, flags);
>>  }
>>  
>>  static const struct i2c_lock_operations proxy_lock_ops = {
>> -- 
>> 2.47.3

-- 
Jani Nikula, Intel