Re: [PATCH v10 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier

[YLCHANG2 <neo.chang70@gmail.com>]

On 9/10/26 22:33, Dan Carpenter wrote:
> On Tue, Aug 25, 2026 at 10:16:44AM +0800, Neo Chang wrote:
>> +static int nau8360_dac_mux_put_enum(struct snd_kcontrol *kcontrol,
>> +	struct snd_ctl_elem_value *ucontrol)
>> +{
>> +	struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_to_dapm(kcontrol);
>> +	struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
>> +	struct nau8360 *nau8360 = snd_soc_component_get_drvdata(component);
>> +	struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
>> +	unsigned int *item = ucontrol->value.enumerated.item;
>> +	int ret = 0;
>> +
>> +	if (snd_soc_dapm_get_bias_level(dapm) > SND_SOC_BIAS_STANDBY) {
>> +		dev_warn(nau8360->dev, "changing path is not allowed during playback");
>> +		return ret;
> This is another case where I would prefer return 0 or return -EINVAL.
>
>> +	}
>> +
>> +	mutex_lock(&nau8360->lock);
>> +
>> +	ret = snd_soc_dapm_put_enum_double(kcontrol, ucontrol);
> Not related to your patch but the comments to snd_soc_dapm_put_enum_double()
> say "Returns 0 for success." when really it returns true/false on success
> where true means it changed something and false means nothing changed.
>
> regards,
> dan carpenter
Hi Dan,

Got it. I will change return ret; to return -EBUSY; for the playback 
check condition in the next patch.
Also, thanks for the heads-up regarding snd_soc_dapm_put_enum_double(). 
I'll keep that in mind.
>
>> +	if (ret <= 0)
>> +		goto unlock;
>> +
>> +	nau8360_dsp_switch(component, snd_soc_enum_item_to_val(e, item[0]));
>> +
>> +unlock:
>> +	mutex_unlock(&nau8360->lock);
>> +
>> +	return ret;
>> +}