From: Krzysztof Kozlowski <krzk@kernel.org>
To: Huan He <hehuan1@eswincomputing.com>, conor+dt@kernel.org
Cc: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ningyu@eswincomputing.com, linmin@eswincomputing.com,
pinkesh.vaghela@einfochips.com, luyulin@eswincomputing.com,
conor.dooley@microchip.com
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor
Date: Sun, 3 May 2026 14:05:46 +0200 [thread overview]
Message-ID: <cc80f651-5e01-4ec2-8ddb-aa91da28fca9@kernel.org> (raw)
In-Reply-To: <28b4eea0.5ad0.19dcdd49d49.Coremail.hehuan1@eswincomputing.com>
On 27/04/2026 09:25, Huan He wrote:
> Hi Conor,
>
> The label property is currently declared as 'label: true' without any
> value constraints. However, the driver expects specific label values (pvt0
> or pvt1). Is it ok to update the DT binding schema to constrain the label
> property to an enum:
>
No, drop label completely in such case. You misuse this property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-03 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:43 [PATCH v3 0/2] Add driver support for ESWIN EIC7700 PVT controller hehuan1
2026-03-06 9:45 ` [PATCH v3 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor hehuan1
2026-04-27 7:25 ` Huan He
2026-05-03 12:05 ` Krzysztof Kozlowski [this message]
2026-03-06 9:47 ` [PATCH v3 2/2] hwmon: Add Eswin EIC7700 PVT sensor driver hehuan1
2026-03-06 16:08 ` Guenter Roeck
2026-03-12 12:28 ` Huan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc80f651-5e01-4ec2-8ddb-aa91da28fca9@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=hehuan1@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luyulin@eswincomputing.com \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.