From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69CDFC433EF for ; Fri, 10 Dec 2021 07:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VH4eW4uDz/VyAfWAcbOg4GSVq6ryQthf9RJgEocgQiU=; b=dHwTLujZzNyrlo h/SjDC1RiaEeG5wUj7ud0dPtD95QwytIvrUfGHl7WJje5xYNyYKdgmSxAKzsNAlET1IMtgwxWr1uY V6uP3QQ3Pq2HhCdZAHRHBaXK6kiROYlWla9lunYeyQVWe04u0qkoPiWamnkbbQlEjYPLoVGbzPSX2 YqF5OmY7CudTsT/NMACBYIBpZNOy8dFCITb+WE73p5i/tShcg/vhw5GCiy8+faQzthJj5kkaEtVfh RwX+Pko5Up3U0piKhkaqagJctmKkHCf7mnETWaM06buzO3GIYrVfE43/WIaPr1L74OU1+Re/pEx64 piBWAqrMfPVM908zbSLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvaVM-0014hq-PV; Fri, 10 Dec 2021 07:39:44 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvaVI-0014gk-S2 for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 07:39:42 +0000 Received: by mail-lj1-x230.google.com with SMTP id a37so11398410ljq.13 for ; Thu, 09 Dec 2021 23:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=AA2QRu1j+KXwSFiRDZh+BE+5TYK9vAtNOlEYRWlHjwQ=; b=iLB0zxWOhbsp62cnauOqtvZ6GSyBPZbQExfccv/4o2moPwIprc7RSQwzcYV99OUe/N Sesf3cT7VeUmkRc1MOsvC01BWcRAzKKl3EykUatzSdj+qASemVSPwTuDLTvGdJDlcjAW G99wRC6nzM5tZ7ekoY1UXFyzrtBJ8SShlocWWIxh2IJi5RX5GAMB1bciPutc0M8kGieA 5zT/+0pl21B6Tl0/vR7uuBdTAzGxGq4PbsNRPcCt3V9YgXByhTKJNNhSEmFHeUDff323 XRgMk8CWMaga4RStZxIr2aPkjWJz5cBmL2HMm4ZwGQXbS9ROS7vFs885+Xqq2OcjKgE5 tyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=AA2QRu1j+KXwSFiRDZh+BE+5TYK9vAtNOlEYRWlHjwQ=; b=xCsPfYt/HGwfXBvWf6k123z7QXvh4xBVhsc+xr0ngiI7Xyu599esneg7pB9eIef1dz CbYcQlKh63L8yUTCR27GSG+lh4UiAbhlbbw7N9J588pI21ZkC7ShGmKZ+gvEHOW9E0Wf 7mAStFQXoIqSu8M3d4U48ZHBtwUk29TYxtdxbLQHEUmrkl3BEB0oVs5qJffLNvfWQuji bYY7v+ZGe+Yi92Vcp2kMmexBSP31kX7CCuXPIYdN2ZdKNRM389zj3J9cayEpGHyy9GVC WgWriGTqJcYBsWVrr13eVdijpUlXPOXKw2o/yseretMxlKD1oWoLguMObmEzjfdVrQ3g glWA== X-Gm-Message-State: AOAM532Xlrq/y7PMGpnCFVVXX2AMvBl8t/fSdSXX1QfTSpKPIl1sz0Bu eMCNmz0pg4L0cX9Pa4Co8KRKRxf8/vA= X-Google-Smtp-Source: ABdhPJw4Cy9i8/DIU7BY3H4BhSgH0WotzDqMUJWR7YNJ6RC4lYCVTNqnNLql4LM3f328MuMQfFIELQ== X-Received: by 2002:a2e:9ed6:: with SMTP id h22mr11106621ljk.410.1639121978673; Thu, 09 Dec 2021 23:39:38 -0800 (PST) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id v2sm229254ljv.6.2021.12.09.23.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 23:39:38 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 08:39:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2 To: Lisa Hill , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Hauke Mehrtens Cc: Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <74E33696-D05A-4009-8C40-927A4DBDD4EF@icloud.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <74E33696-D05A-4009-8C40-927A4DBDD4EF@icloud.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_233940_947687_77D93F97 X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.12.2021 07:53, Lisa Hill wrote: > Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2. > > Signed-off-by: Lisa Hill Nice work! One more comment on sending patches: please configure your e-mail client to send text only (text/plain) without extra HTML version (text/html). If you can't configure your e-mail easily you can also try "git send-email" command line tool. See: https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text https://www.kernel.org/doc/html/v5.15/process/email-clients.html Also see comments below. > --- > .../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > index 4c60eda296d973..5810c95ab239ae 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > @@ -34,20 +34,33 @@ > linux,default-trigger = "default-on"; > }; > > - power0 { > + power-green { > label = "bcm53xx:green:power"; > gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "default-on"; > }; > > - power1 { > + power-amber { > label = "bcm53xx:amber:power"; > gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "default-on"; > }; > > usb { > label = "bcm53xx:blue:usb"; > gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>; > + trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>; > + linux,default-trigger = "usbport"; > + }; > + No tabs in empty separator line please. > + wan-green { > + label = "bcm53xx:green:wan"; > + gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "default-on"; I think it's a rather bad idea to blindly set WAN LED on. It should be up to operating system to decide under what conditions turn it on. I think you should drop that linux,default-trigger. > + }; > + No tabs in empty separator line please. > + wan-amber { > + label = "bcm53xx:amber:wan"; > + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>; > }; It's unlikely both WAN LEDs (green & amber) are controlled by the same GPIO (10). Please verify that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0175C433EF for ; Fri, 10 Dec 2021 07:39:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbhLJHnP (ORCPT ); Fri, 10 Dec 2021 02:43:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhLJHnP (ORCPT ); Fri, 10 Dec 2021 02:43:15 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E20EC061746 for ; Thu, 9 Dec 2021 23:39:40 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id v15so12572332ljc.0 for ; Thu, 09 Dec 2021 23:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=AA2QRu1j+KXwSFiRDZh+BE+5TYK9vAtNOlEYRWlHjwQ=; b=iLB0zxWOhbsp62cnauOqtvZ6GSyBPZbQExfccv/4o2moPwIprc7RSQwzcYV99OUe/N Sesf3cT7VeUmkRc1MOsvC01BWcRAzKKl3EykUatzSdj+qASemVSPwTuDLTvGdJDlcjAW G99wRC6nzM5tZ7ekoY1UXFyzrtBJ8SShlocWWIxh2IJi5RX5GAMB1bciPutc0M8kGieA 5zT/+0pl21B6Tl0/vR7uuBdTAzGxGq4PbsNRPcCt3V9YgXByhTKJNNhSEmFHeUDff323 XRgMk8CWMaga4RStZxIr2aPkjWJz5cBmL2HMm4ZwGQXbS9ROS7vFs885+Xqq2OcjKgE5 tyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=AA2QRu1j+KXwSFiRDZh+BE+5TYK9vAtNOlEYRWlHjwQ=; b=DixohUw0cvi7VJtlKD9Iayp0YKkZ/af8XPWPCQXhPixVQlLC2dIlr4CfB+yreIQOSd Kkay7B0NX80rZJriT/KO6yvXfBV8mJuA28t4xutKRlPngZ3xD9xuJYtelR8IjFVw7MfV jhcrZ6lWmBaVVxdbunTqsdqSCvdGR2GePfK7OS573LE5P/sGQYEsJ+GSYdZwXlE7R7a7 GxWeGmeeieIMVLFkpYSIaE/NPi0y7AHX7DJSE/DrcHns63DNZNGHRKYtzfxSpyzn9fXF 4io/0aOtcFn34hXJo60ZTJ6ICTJ8l9BTYKqysq5rAlynvvh4tp1/QxX8580aBlZQ6yP5 JyPA== X-Gm-Message-State: AOAM531xIPEzDAnYtkFsvy24hcVwJ5s0lg4lFD7DxlI7hYn5yczG0mHy eYs3rSvmY9bQwyVAqDvbim8= X-Google-Smtp-Source: ABdhPJw4Cy9i8/DIU7BY3H4BhSgH0WotzDqMUJWR7YNJ6RC4lYCVTNqnNLql4LM3f328MuMQfFIELQ== X-Received: by 2002:a2e:9ed6:: with SMTP id h22mr11106621ljk.410.1639121978673; Thu, 09 Dec 2021 23:39:38 -0800 (PST) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id v2sm229254ljv.6.2021.12.09.23.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 23:39:38 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 08:39:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2 To: Lisa Hill , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Hauke Mehrtens Cc: Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <74E33696-D05A-4009-8C40-927A4DBDD4EF@icloud.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <74E33696-D05A-4009-8C40-927A4DBDD4EF@icloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10.12.2021 07:53, Lisa Hill wrote: > Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2. > > Signed-off-by: Lisa Hill Nice work! One more comment on sending patches: please configure your e-mail client to send text only (text/plain) without extra HTML version (text/html). If you can't configure your e-mail easily you can also try "git send-email" command line tool. See: https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text https://www.kernel.org/doc/html/v5.15/process/email-clients.html Also see comments below. > --- > .../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > index 4c60eda296d973..5810c95ab239ae 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > @@ -34,20 +34,33 @@ > linux,default-trigger = "default-on"; > }; > > - power0 { > + power-green { > label = "bcm53xx:green:power"; > gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "default-on"; > }; > > - power1 { > + power-amber { > label = "bcm53xx:amber:power"; > gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>; > - linux,default-trigger = "default-on"; > }; > > usb { > label = "bcm53xx:blue:usb"; > gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>; > + trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>; > + linux,default-trigger = "usbport"; > + }; > + No tabs in empty separator line please. > + wan-green { > + label = "bcm53xx:green:wan"; > + gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "default-on"; I think it's a rather bad idea to blindly set WAN LED on. It should be up to operating system to decide under what conditions turn it on. I think you should drop that linux,default-trigger. > + }; > + No tabs in empty separator line please. > + wan-amber { > + label = "bcm53xx:amber:wan"; > + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>; > }; It's unlikely both WAN LEDs (green & amber) are controlled by the same GPIO (10). Please verify that.