Re: [EXTERNAL] Re: [dunfell][PATCH v2 0/3] qtwebkit: Fix no x11 build

["Tammana, Gowtham" <g-tammana@ti.com>]

>-----Original Message-----
>From: Denys Dmytriyenko <denis@denix.org>
>Sent: Monday, April 05, 2021 4:20 PM
>To: Tammana, Gowtham <g-tammana@ti.com>
>Cc: meta-arago@arago-project.org; Bajjuri, Praneeth <praneeth@ti.com>;
>denys@konsulko.com; Bhargav, Krunal <k-bhargav@ti.com>
>Subject: [EXTERNAL] Re: [meta-arago] [dunfell][PATCH v2 0/3] qtwebkit: Fix
>no x11 build
>
>On Mon, Apr 05, 2021 at 03:39:25PM -0500, Gowtham Tammana wrote:
>> qtwebkit build was failing when x11 is enabled for the platform.
>
>I guess another typo enabled/disabled here?

Yes another typo ☹ should have been disabled.

>If so, I don't think it requires another revision, as this is just a cover
>letter and actual patches seem fine. Thanks.

Thanks for the review.
Gowtham

>> This was due to
>> qtwebkit build not picking up the EGL_NO_X11 flag from the
>packageconfig. This
>> was earlier fixed by enabling the flag directly in the khrplatform
>header file.
>> Fixing up to pass the flag to build environment itself.
>>
>> Also cleaned up some of the old patches.
>>
>> v2:
>>   - fixed typo in patch 2/3 (qtwebkit: Fix no X11 build)
>>
>> Gowtham Tammana (3):
>>   Revert "HACK: qtwebkit: define MESA_EGL_NO_X11_HEADERS at
>>     ANGLE/khrplatform.h"
>>   qtwebkit: Fix no X11 build
>>   qtwebkit: Cleanup old patches
>>
>>  ...atform.h-add-define-MESA_EGL_NO_X11_.patch | 30 ------------
>>  ...e-to-use-GL_NoX-version-of-GraphicsS.patch | 29 ------------
>>  ...re-PlatformQt.cmake-Fix-no-x11-build.patch | 46 +++++++++++++++++++
>>  .../qt5/qtwebkit/GraphicsSurfaceToken.h.patch | 33 -------------
>>  .../recipes-qt/qt5/qtwebkit/WebCore.pri.patch | 17 -------
>>  .../recipes-qt/qt5/qtwebkit_%.bbappend        |  8 +---
>>  6 files changed, 48 insertions(+), 115 deletions(-)
>>  delete mode 100644 meta-arago-distro/recipes-qt/qt5/qtwebkit/0001-HACK-
>ANGLE-khrplatform.h-add-define-MESA_EGL_NO_X11_.patch
>>  delete mode 100644 meta-arago-distro/recipes-qt/qt5/qtwebkit/0001-
>Target.pri-update-to-use-GL_NoX-version-of-GraphicsS.patch
>>  create mode 100644 meta-arago-distro/recipes-qt/qt5/qtwebkit/0001-
>WebCore-PlatformQt.cmake-Fix-no-x11-build.patch
>>  delete mode 100644 meta-arago-distro/recipes-
>qt/qt5/qtwebkit/GraphicsSurfaceToken.h.patch
>>  delete mode 100644 meta-arago-distro/recipes-
>qt/qt5/qtwebkit/WebCore.pri.patch
>>
>> --
>> 2.31.1
>>
>
>--
>Regards,
>Denys Dmytriyenko <denis@denix.org>
>PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
>Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964